Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2531713002: [ash-md] Update text layout in system menu. (Closed)

Created:
4 years ago by bruthig
Modified:
4 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Update text layout in system menu. Removes the vertical padding between multi label rows and moves the date text in the system info row 4 dp to the right. BUG=668333, 667944 Committed: https://crrev.com/445aa4a62b3f74e3276bfd83bceaf9c4699a734f Cr-Commit-Position: refs/heads/master@{#434416}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed right padding to be 8. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ash/common/system/date/date_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
bruthig
tdanderson@, can you take a quick look?
4 years ago (2016-11-24 23:18:40 UTC) #4
tdanderson
LGTM with the comments addressed https://codereview.chromium.org/2531713002/diff/1/ash/common/system/date/date_view.cc File ash/common/system/date/date_view.cc (right): https://codereview.chromium.org/2531713002/diff/1/ash/common/system/date/date_view.cc#newcode171 ash/common/system/date/date_view.cc:171: box_layout->set_inside_border_insets(gfx::Insets(0, 12, 0, 0)); ...
4 years ago (2016-11-25 00:01:38 UTC) #7
bruthig
Good catch ;) Sending to CQ... https://codereview.chromium.org/2531713002/diff/1/ash/common/system/date/date_view.cc File ash/common/system/date/date_view.cc (right): https://codereview.chromium.org/2531713002/diff/1/ash/common/system/date/date_view.cc#newcode171 ash/common/system/date/date_view.cc:171: box_layout->set_inside_border_insets(gfx::Insets(0, 12, 0, ...
4 years ago (2016-11-25 00:15:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531713002/20001
4 years ago (2016-11-25 00:15:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 01:01:20 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-25 01:03:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/445aa4a62b3f74e3276bfd83bceaf9c4699a734f
Cr-Commit-Position: refs/heads/master@{#434416}

Powered by Google App Engine
This is Rietveld 408576698