Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic-inl.h

Issue 25260002: Always store stubs on the JSObject receiver, even when in slow mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 heap->mark_compact_collector()->RecordCodeTargetPatch(address, target); 95 heap->mark_compact_collector()->RecordCodeTargetPatch(address, target);
96 } else { 96 } else {
97 heap->incremental_marking()->RecordCodeTargetPatch(address, target); 97 heap->incremental_marking()->RecordCodeTargetPatch(address, target);
98 } 98 }
99 PostPatching(address, target, old_target); 99 PostPatching(address, target, old_target);
100 } 100 }
101 101
102 102
103 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 103 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
104 JSObject* holder) { 104 JSObject* holder) {
105 if (object->IsJSObject()) { 105 if (object->IsJSObject()) return OWN_MAP;
106 return GetCodeCacheForObject(JSObject::cast(object), holder); 106
107 }
108 // If the object is a value, we use the prototype map for the cache. 107 // If the object is a value, we use the prototype map for the cache.
109 ASSERT(object->IsString() || object->IsSymbol() || 108 ASSERT(object->IsString() || object->IsSymbol() ||
110 object->IsNumber() || object->IsBoolean()); 109 object->IsNumber() || object->IsBoolean());
111 return PROTOTYPE_MAP; 110 return PROTOTYPE_MAP;
112 } 111 }
113 112
114 113
115 InlineCacheHolderFlag IC::GetCodeCacheForObject(JSObject* object,
116 JSObject* holder) {
117 // Fast-properties and global objects store stubs in their own maps.
118 // Slow properties objects use prototype's map (unless the property is its own
119 // when holder == object). It works because slow properties objects having
120 // the same prototype (or a prototype with the same map) and not having
121 // the property are interchangeable for such a stub.
122 if (holder != object &&
123 !object->HasFastProperties() &&
124 !object->IsJSGlobalProxy() &&
125 !object->IsJSGlobalObject()) {
126 return PROTOTYPE_MAP;
127 }
128 return OWN_MAP;
129 }
130
131
132 JSObject* IC::GetCodeCacheHolder(Isolate* isolate, 114 JSObject* IC::GetCodeCacheHolder(Isolate* isolate,
133 Object* object, 115 Object* object,
134 InlineCacheHolderFlag holder) { 116 InlineCacheHolderFlag holder) {
135 Object* map_owner = 117 Object* map_owner =
136 holder == OWN_MAP ? object : object->GetPrototype(isolate); 118 holder == OWN_MAP ? object : object->GetPrototype(isolate);
137 ASSERT(map_owner->IsJSObject()); 119 ASSERT(map_owner->IsJSObject());
138 return JSObject::cast(map_owner); 120 return JSObject::cast(map_owner);
139 } 121 }
140 122
141 123
142 } } // namespace v8::internal 124 } } // namespace v8::internal
143 125
144 #endif // V8_IC_INL_H_ 126 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698