ui/views/controls/window_label.cc - Issue 251103005: Added arrow key navigation to Overview Mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/controls/window_label.cc

Issue 251103005: Added arrow key navigation to Overview Mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with latest changes, test stub (don't look into that yet!) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/views/controls/window_label.h"

	6

	7 #include "ui/accessibility/ax_view_state.h"

	8 #include "ui/views/controls/label.h"

	9

	10 namespace views {

	11

	12 WindowLabel::WindowLabel() : Label() {

	13 }

	14 WindowLabel::~WindowLabel() {

	15 }

	16

	17 void WindowLabel::GetAccessibleState(ui::AXViewState* state) {

	18 // TODO(dmazzoni) Change role to "window"
	tdanderson 2014/04/29 14:46:27 Add : after (dmazzoni), and add . at the end of th Add : after (dmazzoni), and add . at the end of the comment. Also make sure Dominic knows this TODO is in the code (and ideally there should be a bug tracking the work, too). Nina 2014/04/29 18:31:40 Done, and he does know the TODO. We should probabl Show quoted text On 2014/04/29 14:46:27, tdanderson wrote: > Add : after (dmazzoni), and add . at the end of the comment. Also make sure > Dominic knows this TODO is in the code (and ideally there should be a bug > tracking the work, too). Done, and he does know the TODO. We should probably file the bug when the patch gets landed.
	19 state->role = ui::AX_ROLE_BUTTON;

	20 state->AddStateFlag(ui::AX_STATE_READ_ONLY);

	21 state->name = layout_text();

	22 }

	23

	24 } // namespace views

OLD	NEW