Added arrow key navigation to Overview Mode

ash/wm/overview/window_selector_item.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_selector_item.h"
 
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/overview/scoped_transform_overview_window.h"
 #include "base/auto_reset.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/aura/window.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
-#include "ui/views/controls/label.h"
+#include "ui/views/controls/window_label.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 // Foreground label color.
 static const SkColor kLabelColor = SK_ColorWHITE;
 
 // Background label color.
 static const SkColor kLabelBackground = SK_ColorTRANSPARENT;
 
 // Label shadow color.
 static const SkColor kLabelShadow = 0xB0000000;
 
 // Vertical padding for the label, both over and beneath it.
 static const int kVerticalLabelPadding = 20;
 
 // Solid shadow length from the label
 static const int kVerticalShadowOffset = 1;
 
 // Amount of blur applied to the label shadow
 static const int kShadowBlur = 10;
 
 views::Widget* CreateWindowLabel(aura::Window* root_window,
                                  const base::string16 title) {
   views::Widget* widget = new views::Widget;
   views::Widget::InitParams params;
   params.type = views::Widget::InitParams::TYPE_POPUP;
-  params.can_activate = false;
+  params.can_activate = true;
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
   params.parent =
       Shell::GetContainer(root_window, ash::kShellWindowId_OverlayContainer);
   params.accept_events = false;
-  params.visible_on_all_workspaces = true;

[tdanderson, 2014/04/29 14:46:27]

Why are you removing this?

[Nina, 2014/04/29 18:31:40]

Actually, because I don't know how it got there. When I was working in the label
stuff I tested that option… along with a dozen others. Not sure if it has an
effect on the label.

   widget->set_focus_on_creation(false);
   widget->Init(params);
-  views::Label* label = new views::Label;
+  views::WindowLabel* label = new views::WindowLabel;

[tdanderson, 2014/04/29 14:46:27]

I think that introducing a new class is overkill here. WindowLabel only has one
method, and its implementation is almost identical to the one in the base class.
How about this instead:

* Add a member to Label of type AXRole and initialize it to AX_ROLE_STATIC_TEXT
in the Label constructor.
* Then at line 53 here, create a Label as before but then say
label->SetAXRole(AX_ROLE_BUTTON) along with the TODO for Dominic.

What do you think?

   label->SetEnabledColor(kLabelColor);
   label->SetBackgroundColor(kLabelBackground);
   label->SetShadowColors(kLabelShadow, kLabelShadow);
   label->SetShadowOffset(0, kVerticalShadowOffset);
   label->set_shadow_blur(kShadowBlur);
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   label->SetFontList(bundle.GetFontList(ui::ResourceBundle::BoldFont));
   label->SetText(title);
   views::BoxLayout* layout = new views::BoxLayout(views::BoxLayout::kVertical,
                                                   0,
@@ skipping 83 matching lines @@
           window_label_->GetNativeWindow()->layer()->GetAnimator());
       settings.SetPreemptionStrategy(
           ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
       settings.SetTransitionDuration(base::TimeDelta::FromMilliseconds(
           ScopedTransformOverviewWindow::kTransitionMilliseconds));
       window_label_->GetNativeWindow()->SetBounds(label_bounds);
     } else {
       window_label_->GetNativeWindow()->SetBounds(label_bounds);
     }
   }
+}
 
+views::Widget* WindowSelectorItem::get_window_label() {
+  return window_label_.get();

[tdanderson, 2014/04/29 14:46:27]

Since this is a simple accessor, you can move the implementation into the .h

[Nina, 2014/04/29 18:31:40]

Done.

 }
 
 }  // namespace ash