Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 25092003: Added missing @viewport to the simple UA stylesheet. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added missing @viewport to the simple UA stylesheet. @viewport UA rule also required when the simple UA styles should otherwise suffice to style the document. BUG=298477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158488

Patch Set 1 #

Patch Set 2 : Retried after old chunk mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
A LayoutTests/css3/device-adapt/viewport-user-agent-style.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/css3/device-adapt/viewport-user-agent-style-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
7 years, 2 months ago (2013-09-27 20:14:56 UTC) #1
aelias_OOO_until_Jul13
Thanks for the fix. I can't see the patch because of "error: old chunk mismatch"; ...
7 years, 2 months ago (2013-09-27 21:02:30 UTC) #2
rune
On 2013/09/27 21:02:30, aelias wrote: > Thanks for the fix. I can't see the patch ...
7 years, 2 months ago (2013-09-27 21:10:25 UTC) #3
aelias_OOO_until_Jul13
lgtm. Elliot, can you approve?
7 years, 2 months ago (2013-09-27 21:57:58 UTC) #4
esprehn
lgtm
7 years, 2 months ago (2013-09-27 22:08:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25092003/9001
7 years, 2 months ago (2013-09-27 23:04:26 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-28 04:37:57 UTC) #7
Message was sent while issue was closed.
Change committed as 158488

Powered by Google App Engine
This is Rietveld 408576698