Issue 25090002: Make strict_mode a flag on StoreIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25090002: Make strict_mode a flag on StoreIC. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make strict_mode a flag on StoreIC. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17035

Patch Set 2 : Move setting strictmode to the constructor #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -175 lines)			Patch
	M	src/ic.h	View	1	10 chunks	+76 lines, -72 lines	1 comment	Download
	M	src/ic.cc	View	1	48 chunks	+57 lines, -103 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/25090002/diff/4001/src/ic.h File src/ic.h (right): https://chromiumcodereview.appspot.com/25090002/diff/4001/src/ic.h#newcode544 src/ic.h:544: if (strict_mode() == kStrictMode) { Let's use strict_mode_ ...

7 years, 2 months ago (2013-10-01 08:38:42 UTC) #2

Toon Verwaest

7 years, 2 months ago (2013-10-01 09:36:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17035 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25090002: Make strict_mode a flag on StoreIC. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Move setting strictmode to the constructor #

Messages