Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3576)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator.cc

Issue 25073002: Remove bogus DCHECK for retail startup pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index f23794bd8623d3bd597757e09cfded7615d85c66..7f4e6428ee376c8007f54bbaf6dda16167e9f64c 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -364,11 +364,9 @@ SessionStartupPref StartupBrowserCreator::GetSessionStartupPref(
}
#if defined(OS_CHROMEOS)
- // Kiosk/Retail mode has no profile to restore and fails to open the tabs
- // specified in the startup_urls policy if we try to restore the non-existent
- // session which is the default for ChromeOS in general.
+ // Kiosk/Retail mode receives startup URLs through device settings. They are
+ // appended to the command line, which requires type DEFAULT to work.
if (chromeos::KioskModeSettings::Get()->IsKioskModeEnabled()) {
pastarmovj 2013/09/27 15:48:25 No need for { }.
Mattias Nissler (ping if slow) 2013/09/27 15:52:13 Done.
- DCHECK(pref.type == SessionStartupPref::LAST);
pref.type = SessionStartupPref::DEFAULT;
}
#endif // OS_CHROMEOS
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698