Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: src/x64/ic-x64.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1312 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 1323
1324 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 1324 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
1325 // ----------- S t a t e ------------- 1325 // ----------- S t a t e -------------
1326 // -- rax : receiver 1326 // -- rax : receiver
1327 // -- rcx : name 1327 // -- rcx : name
1328 // -- rsp[0] : return address 1328 // -- rsp[0] : return address
1329 // ----------------------------------- 1329 // -----------------------------------
1330 1330
1331 // Probe the stub cache. 1331 // Probe the stub cache.
1332 Code::Flags flags = Code::ComputeFlags( 1332 Code::Flags flags = Code::ComputeFlags(
1333 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 1333 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
1334 Code::NORMAL, Code::LOAD_IC); 1334 Code::NORMAL, Code::LOAD_IC);
1335 masm->isolate()->stub_cache()->GenerateProbe( 1335 masm->isolate()->stub_cache()->GenerateProbe(
1336 masm, flags, rax, rcx, rbx, rdx); 1336 masm, flags, rax, rcx, rbx, rdx);
1337 1337
1338 GenerateMiss(masm); 1338 GenerateMiss(masm);
1339 } 1339 }
1340 1340
1341 1341
1342 void LoadIC::GenerateNormal(MacroAssembler* masm) { 1342 void LoadIC::GenerateNormal(MacroAssembler* masm) {
1343 // ----------- S t a t e ------------- 1343 // ----------- S t a t e -------------
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 StrictModeFlag strict_mode) { 1444 StrictModeFlag strict_mode) {
1445 // ----------- S t a t e ------------- 1445 // ----------- S t a t e -------------
1446 // -- rax : value 1446 // -- rax : value
1447 // -- rcx : name 1447 // -- rcx : name
1448 // -- rdx : receiver 1448 // -- rdx : receiver
1449 // -- rsp[0] : return address 1449 // -- rsp[0] : return address
1450 // ----------------------------------- 1450 // -----------------------------------
1451 1451
1452 // Get the receiver from the stack and probe the stub cache. 1452 // Get the receiver from the stack and probe the stub cache.
1453 Code::Flags flags = Code::ComputeFlags( 1453 Code::Flags flags = Code::ComputeFlags(
1454 Code::STUB, MONOMORPHIC, strict_mode, 1454 Code::HANDLER, MONOMORPHIC, strict_mode,
1455 Code::NORMAL, Code::STORE_IC); 1455 Code::NORMAL, Code::STORE_IC);
1456 masm->isolate()->stub_cache()->GenerateProbe( 1456 masm->isolate()->stub_cache()->GenerateProbe(
1457 masm, flags, rdx, rcx, rbx, no_reg); 1457 masm, flags, rdx, rcx, rbx, no_reg);
1458 1458
1459 // Cache miss: Jump to runtime. 1459 // Cache miss: Jump to runtime.
1460 GenerateMiss(masm); 1460 GenerateMiss(masm);
1461 } 1461 }
1462 1462
1463 1463
1464 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1464 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1678 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1679 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1679 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1680 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1680 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1681 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1681 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1682 } 1682 }
1683 1683
1684 1684
1685 } } // namespace v8::internal 1685 } } // namespace v8::internal
1686 1686
1687 #endif // V8_TARGET_ARCH_X64 1687 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698