Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/disassembler.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 1297
1298 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 1298 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
1299 // ----------- S t a t e ------------- 1299 // ----------- S t a t e -------------
1300 // -- ecx : name 1300 // -- ecx : name
1301 // -- edx : receiver 1301 // -- edx : receiver
1302 // -- esp[0] : return address 1302 // -- esp[0] : return address
1303 // ----------------------------------- 1303 // -----------------------------------
1304 1304
1305 // Probe the stub cache. 1305 // Probe the stub cache.
1306 Code::Flags flags = Code::ComputeFlags( 1306 Code::Flags flags = Code::ComputeFlags(
1307 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 1307 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
1308 Code::NORMAL, Code::LOAD_IC); 1308 Code::NORMAL, Code::LOAD_IC);
1309 masm->isolate()->stub_cache()->GenerateProbe( 1309 masm->isolate()->stub_cache()->GenerateProbe(
1310 masm, flags, edx, ecx, ebx, eax); 1310 masm, flags, edx, ecx, ebx, eax);
1311 1311
1312 // Cache miss: Jump to runtime. 1312 // Cache miss: Jump to runtime.
1313 GenerateMiss(masm); 1313 GenerateMiss(masm);
1314 } 1314 }
1315 1315
1316 1316
1317 void LoadIC::GenerateNormal(MacroAssembler* masm) { 1317 void LoadIC::GenerateNormal(MacroAssembler* masm) {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
1416 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1416 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1417 StrictModeFlag strict_mode) { 1417 StrictModeFlag strict_mode) {
1418 // ----------- S t a t e ------------- 1418 // ----------- S t a t e -------------
1419 // -- eax : value 1419 // -- eax : value
1420 // -- ecx : name 1420 // -- ecx : name
1421 // -- edx : receiver 1421 // -- edx : receiver
1422 // -- esp[0] : return address 1422 // -- esp[0] : return address
1423 // ----------------------------------- 1423 // -----------------------------------
1424 1424
1425 Code::Flags flags = Code::ComputeFlags( 1425 Code::Flags flags = Code::ComputeFlags(
1426 Code::STUB, MONOMORPHIC, strict_mode, 1426 Code::HANDLER, MONOMORPHIC, strict_mode,
1427 Code::NORMAL, Code::STORE_IC); 1427 Code::NORMAL, Code::STORE_IC);
1428 masm->isolate()->stub_cache()->GenerateProbe( 1428 masm->isolate()->stub_cache()->GenerateProbe(
1429 masm, flags, edx, ecx, ebx, no_reg); 1429 masm, flags, edx, ecx, ebx, no_reg);
1430 1430
1431 // Cache miss: Jump to runtime. 1431 // Cache miss: Jump to runtime.
1432 GenerateMiss(masm); 1432 GenerateMiss(masm);
1433 } 1433 }
1434 1434
1435 1435
1436 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1436 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1658 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1658 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1659 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1659 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1660 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1660 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1661 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1661 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1662 } 1662 }
1663 1663
1664 1664
1665 } } // namespace v8::internal 1665 } } // namespace v8::internal
1666 1666
1667 #endif // V8_TARGET_ARCH_IA32 1667 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/disassembler.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698