Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 250063002: Browser Plugin: Simplified guest attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 1325ac4ca0df500b1ffcae4a294d7d0c66cdbbe1..c35b00be1435ac686a82e81daab2984beff72cba 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -46,8 +46,6 @@ class CONTENT_EXPORT BrowserPlugin :
return browser_plugin_manager_.get();
}
- static BrowserPlugin* FromContainer(blink::WebPluginContainer* container);
-
bool OnMessageReceived(const IPC::Message& msg);
// Update Browser Plugin's DOM Node attribute |attribute_name| with the value
@@ -109,11 +107,6 @@ class CONTENT_EXPORT BrowserPlugin :
// Returns whether this BrowserPlugin has allocated an instance ID.
bool HasGuestInstanceID() const;
- // Attaches the window identified by |window_id| to the the given node
- // encapsulating a BrowserPlugin.
- static bool AttachWindowTo(const blink::WebNode& node,
- int window_id);
-
// Informs the guest of an updated focus state.
void UpdateGuestFocusState();
// Indicates whether the guest should be focused.
@@ -131,7 +124,8 @@ class CONTENT_EXPORT BrowserPlugin :
// Provided that a guest instance ID has been allocated, this method attaches
// this BrowserPlugin instance to that guest. |extra_params| are parameters
// passed in by the content embedder to the browser process.
- void Attach(scoped_ptr<base::DictionaryValue> extra_params);
+ void Attach(int guest_instance_id,
+ scoped_ptr<base::DictionaryValue> extra_params);
// Notify the plugin about a compositor commit so that frame ACKs could be
// sent, if needed.

Powered by Google App Engine
This is Rietveld 408576698