Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed clang compile and a minor bug Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index a57c4ccd4cdd9ccab40973a5e06efb9cd90cc526..671ff77ecb03d33c894c259d2278fc2c42d50ac1 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -64,12 +64,11 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {
virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {
return std::string();
}
- virtual RenderViewHost* CreateNewTarget() OVERRIDE { return NULL; }
- virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE {
- return kTargetTypeTab;
+ virtual scoped_refptr<DevToolsTarget> CreateNewTarget() OVERRIDE {
+ return NULL;
}
- virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE {
- return std::string();
+ virtual void EnumerateTargets(TargetCallback callback) OVERRIDE {
+ callback.Run(TargetList());
}
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,

Powered by Google App Engine
This is Rietveld 408576698