Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.h

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Extracted DevToolsTarget class Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.h
diff --git a/content/browser/devtools/devtools_http_handler_impl.h b/content/browser/devtools/devtools_http_handler_impl.h
index f7ccca02d45ab4c7bb5c9022c6c547eb4e9f1343..7f4d4b2928754e5a515dda4c9556b55339731564 100644
--- a/content/browser/devtools/devtools_http_handler_impl.h
+++ b/content/browser/devtools/devtools_http_handler_impl.h
@@ -15,7 +15,6 @@
#include "content/common/content_export.h"
#include "content/public/browser/devtools_http_handler.h"
#include "content/public/browser/devtools_http_handler_delegate.h"
-#include "content/public/browser/worker_service.h"
#include "net/http/http_status_code.h"
#include "net/server/http_server.h"
@@ -53,8 +52,6 @@ class DevToolsHttpHandlerImpl
// DevToolsHttpHandler implementation.
virtual void Stop() OVERRIDE;
- virtual void SetDevToolsAgentHostBinding(
- DevToolsAgentHostBinding* binding) OVERRIDE;
virtual GURL GetFrontendURL(DevToolsAgentHost* agent_host) OVERRIDE;
// net::HttpServer::Delegate implementation.
@@ -80,8 +77,12 @@ class DevToolsHttpHandlerImpl
void ResetHandlerThread();
void ResetHandlerThreadAndRelease();
- void CollectWorkerInfo(base::ListValue* target_list, std::string host);
- void SendTargetList(int connection_id, base::ListValue* target_list);
+ void OnTargetListReceived(
+ int connection_id,
+ const std::string& host,
+ const DevToolsHttpHandlerDelegate::TargetList& targets);
+
+ DevToolsTarget* GetTarget(const std::string& id);
void Init();
void Teardown();
@@ -103,19 +104,11 @@ class DevToolsHttpHandlerImpl
const net::HttpServerRequestInfo& request);
// Returns the front end url without the host at the beginning.
- std::string GetFrontendURLInternal(const std::string rvh_id,
+ std::string GetFrontendURLInternal(const std::string target_id,
const std::string& host);
- base::DictionaryValue* SerializePageInfo(RenderViewHost* rvh,
- const std::string& host);
-
- base::DictionaryValue* SerializeWorkerInfo(
- const WorkerService::WorkerInfo& worker,
- const std::string& host);
-
- void SerializeDebuggerURLs(base::DictionaryValue* dictionary,
- const std::string& id,
- const std::string& host);
+ base::DictionaryValue* SerializeTarget(const DevToolsTarget& target,
+ const std::string& host);
// The thread used by the devtools handler to run server socket.
scoped_ptr<base::Thread> thread_;
@@ -125,9 +118,9 @@ class DevToolsHttpHandlerImpl
scoped_refptr<net::HttpServer> server_;
typedef std::map<int, DevToolsClientHost*> ConnectionToClientHostMap;
ConnectionToClientHostMap connection_to_client_host_ui_;
- scoped_ptr<DevToolsHttpHandlerDelegate> delegate_;
- DevToolsAgentHostBinding* binding_;
- scoped_ptr<DevToolsAgentHostBinding> default_binding_;
+ scoped_refptr<DevToolsHttpHandlerDelegate> delegate_;
+ typedef std::map<std::string, scoped_refptr<DevToolsTarget> > TargetMap;
+ TargetMap target_map_;
scoped_refptr<DevToolsBrowserTarget> browser_target_;
DISALLOW_COPY_AND_ASSIGN(DevToolsHttpHandlerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698