Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5290)

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.h

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Extracted DevToolsTarget class Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/browser_list_tabcontents_provider.h
diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.h b/chrome/browser/devtools/browser_list_tabcontents_provider.h
index 9980aca41ffaa2054bfe31e82a0f98bcd4d2384e..15dfa242f5b1f247f2c45ae933b4aa7448b587b5 100644
--- a/chrome/browser/devtools/browser_list_tabcontents_provider.h
+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.h
@@ -25,14 +25,17 @@ class BrowserListTabContentsProvider
virtual bool BundlesFrontendResources() OVERRIDE;
virtual base::FilePath GetDebugFrontendDir() OVERRIDE;
virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;
- virtual content::RenderViewHost* CreateNewTarget() OVERRIDE;
- virtual TargetType GetTargetType(content::RenderViewHost*) OVERRIDE;
- virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE;
+ virtual scoped_refptr<content::DevToolsTarget> CreateNewTarget() OVERRIDE;
+ virtual void EnumerateTargets(TargetCallback callback) OVERRIDE;
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) OVERRIDE;
private:
+ TargetList CollectWorkerTargets();
+ void RespondWithTargetList(TargetCallback callback,
+ const TargetList& worker_targets);
+
chrome::HostDesktopType host_desktop_type_;
DISALLOW_COPY_AND_ASSIGN(BrowserListTabContentsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698