Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Extracted DevToolsTarget class Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/run_loop.h" 6 #include "base/run_loop.h"
7 #include "content/browser/browser_thread_impl.h" 7 #include "content/browser/browser_thread_impl.h"
8 #include "content/public/browser/devtools_http_handler.h" 8 #include "content/public/browser/devtools_http_handler.h"
9 #include "content/public/browser/devtools_http_handler_delegate.h" 9 #include "content/public/browser/devtools_http_handler_delegate.h"
10 #include "net/socket/stream_listen_socket.h" 10 #include "net/socket/stream_listen_socket.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 class DummyDelegate : public DevToolsHttpHandlerDelegate { 57 class DummyDelegate : public DevToolsHttpHandlerDelegate {
58 public: 58 public:
59 virtual std::string GetDiscoveryPageHTML() OVERRIDE { return std::string(); } 59 virtual std::string GetDiscoveryPageHTML() OVERRIDE { return std::string(); }
60 virtual bool BundlesFrontendResources() OVERRIDE { return true; } 60 virtual bool BundlesFrontendResources() OVERRIDE { return true; }
61 virtual base::FilePath GetDebugFrontendDir() OVERRIDE { 61 virtual base::FilePath GetDebugFrontendDir() OVERRIDE {
62 return base::FilePath(); 62 return base::FilePath();
63 } 63 }
64 virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE { 64 virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {
65 return std::string(); 65 return std::string();
66 } 66 }
67 virtual RenderViewHost* CreateNewTarget() OVERRIDE { return NULL; } 67 virtual scoped_refptr<DevToolsTarget> CreateNewTarget() OVERRIDE {
68 virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE { 68 return NULL;
69 return kTargetTypeTab;
70 } 69 }
71 virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE { 70 virtual void EnumerateTargets(TargetCallback callback) OVERRIDE {
72 return std::string(); 71 callback.Run(TargetList());
73 } 72 }
74 virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering( 73 virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
75 net::StreamListenSocket::Delegate* delegate, 74 net::StreamListenSocket::Delegate* delegate,
76 std::string* name) OVERRIDE { 75 std::string* name) OVERRIDE {
77 return scoped_ptr<net::StreamListenSocket>(); 76 return scoped_ptr<net::StreamListenSocket>();
78 } 77 }
79 }; 78 };
80 79
81 } 80 }
82 81
(...skipping 26 matching lines...) Expand all
109 new DummyDelegate()); 108 new DummyDelegate());
110 // Our dummy socket factory will post a quit message once the server will 109 // Our dummy socket factory will post a quit message once the server will
111 // become ready. 110 // become ready.
112 run_loop.Run(); 111 run_loop.Run();
113 devtools_http_handler_->Stop(); 112 devtools_http_handler_->Stop();
114 // Make sure the handler actually stops. 113 // Make sure the handler actually stops.
115 run_loop_2.Run(); 114 run_loop_2.Run();
116 } 115 }
117 116
118 } // namespace content 117 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698