Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: Source/bindings/v8/ScriptState.h

Issue 24989007: Model each Dart library as its own ScriptState when devtools are enabled. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Ready for review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptState.h
diff --git a/Source/bindings/v8/ScriptState.h b/Source/bindings/v8/ScriptState.h
index 16a4a4a5ccbc16338997adda8e4a8896f34b2b53..020c08a03780d6cdda39c2f995d02c11990aefd0 100644
--- a/Source/bindings/v8/ScriptState.h
+++ b/Source/bindings/v8/ScriptState.h
@@ -35,6 +35,7 @@
#include "bindings/v8/V8Utilities.h"
#include <v8.h>
#include "wtf/Noncopyable.h"
+#include "wtf/text/WTFString.h"
namespace WebCore {
@@ -70,6 +71,10 @@ public:
bool evalEnabled() const;
void setEvalEnabled(bool);
+ virtual const String* name() { return 0; }
+ // FIXME: determine a better name and use an enum of supported languages, etc.
+ virtual bool isJavaScript() { return true; }
+
static ScriptState* forContext(v8::Handle<v8::Context>);
static ScriptState* current();
@@ -79,11 +84,12 @@ protected:
{
}
+ explicit ScriptState(v8::Handle<v8::Context>);
+
~ScriptState();
vsm 2013/09/30 22:08:03 This should now be virtual.
Jacob 2013/10/01 00:07:05 Done.
private:
friend ScriptState* mainWorldScriptState(Frame*);
- explicit ScriptState(v8::Handle<v8::Context>);
static void makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Context>*, ScriptState*);

Powered by Google App Engine
This is Rietveld 408576698