Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: Source/bindings/dart/DartDebugHooks.js

Issue 24989007: Model each Dart library as its own ScriptState when devtools are enabled. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartController.cpp ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartDebugHooks.js
diff --git a/Source/bindings/dart/DartDebugHooks.js b/Source/bindings/dart/DartDebugHooks.js
index 3793cf457749174f4b6c6682bc1f76580866efcd..3d307db4f5b72a30f1fa05c0d498c49b154cdb43 100644
--- a/Source/bindings/dart/DartDebugHooks.js
+++ b/Source/bindings/dart/DartDebugHooks.js
@@ -144,19 +144,6 @@ DartDebug.FrameMirror.prototype = {
evaluate: function(expression, disableBreak)
{
- // FIXME: Dart VM doesn't currently support evaluations. Use
- // JavaScript eval and 'with' statement to emulate evaluation on Dart
- // call frame.
-
- // FIXME: dartbug.com/10434 find a less fragile way to determine whether
- // we need to strip off console API support added by InjectedScript.
- var CONSOLE_API_SUPPORT_HEADER =
- 'with ((this && this.console && this.console._commandLineAPI) || {}) {\n';
- if (expression.indexOf(CONSOLE_API_SUPPORT_HEADER) == 0) {
- expression = expression.substr(expression.indexOf('\n') + 1);
- expression = expression.substr(0, expression.lastIndexOf('\n'));
- }
-
var result = DartDebug.nativeCallbacks.invocationTrampoline(
DartDebug.nativeCallbacks.evaluateInScope,
[expression, this._localScope.receiver(), this._callFrame.functionProxy, this._callFrame.localVariables]);
« no previous file with comments | « Source/bindings/dart/DartController.cpp ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698