Model each Dart library as its own ScriptState when devtools are enabled.

Source/core/inspector/PageRuntimeAgent.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/inspector/PageRuntimeAgent.h"
 
+#include "bindings/dart/DartController.h"
 #include "bindings/v8/DOMWrapperWorld.h"
 #include "bindings/v8/ScriptController.h"
 #include "core/inspector/InjectedScript.h"
 #include "core/inspector/InjectedScriptManager.h"
 #include "core/inspector/InspectorPageAgent.h"
 #include "core/inspector/InspectorState.h"
 #include "core/inspector/InstrumentingAgents.h"
 #include "core/page/Frame.h"
 #include "core/page/Page.h"
 #include "core/page/PageConsole.h"
@@ skipping 117 matching lines @@
 void PageRuntimeAgent::reportExecutionContextCreation()
 {
     Vector<std::pair<ScriptState*, SecurityOrigin*> > isolatedContexts;
     for (Frame* frame = m_inspectedPage->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
         if (!frame->script()->canExecuteScripts(NotAboutToExecuteScript))
             continue;
         String frameId = m_pageAgent->frameId(frame);
 
         ScriptState* scriptState = mainWorldScriptState(frame);
         notifyContextCreated(frameId, scriptState, 0, true);
+        notifyDartContextCreated(frameId, scriptState);
+
         frame->script()->collectIsolatedContexts(isolatedContexts);
         if (isolatedContexts.isEmpty())
             continue;
         for (size_t i = 0; i< isolatedContexts.size(); i++)
             notifyContextCreated(frameId, isolatedContexts[i].first, isolatedContexts[i].second, false);
         isolatedContexts.clear();
     }
 }
 
+void PageRuntimeAgent::notifyDartContextCreated(const String& frameId, ScriptState* v8ScriptState)
+{

[vsm, 2013/10/03 17:59:31]

Is the runtime type of v8ScriptState a ScriptState or a DartScriptState?  If the
latter, can we move code over there?

[jacob314, 2013/10/03 20:43:15]

Unfortunately the runtime type of v8ScriptState is ScriptState.

+    ScriptExecutionContext* scriptExecutionContext = v8ScriptState->scriptExecutionContext();
+    DartController* dartController = DartController::retrieve(scriptExecutionContext);
+    if (dartController) {
+        Vector<ScriptState*> scriptStates;
+        dartController->collectScriptStates(v8ScriptState, scriptStates);
+        for (size_t i = 0; i< scriptStates.size(); i++)
+            notifyContextCreated(frameId, scriptStates[i], 0, false);
+    }
+}
+
 void PageRuntimeAgent::notifyContextCreated(const String& frameId, ScriptState* scriptState, SecurityOrigin* securityOrigin, bool isPageContext)
 {
-    ASSERT(securityOrigin || isPageContext);
+    // FIXME: should Dart scripts have a security origin?

[vsm, 2013/10/03 17:59:31]

I think so.  Can you file a bug on this?

[jacob314, 2013/10/03 20:43:15]

updated comment and filed a bug.
dartbug.com/13801

+    ASSERT(securityOrigin || isPageContext || !scriptState->isJavaScript());
     int executionContextId = injectedScriptManager()->injectedScriptIdFor(scriptState);
-    String name = securityOrigin ? securityOrigin->toRawString() : "";
+    String name = scriptState->name() ? *scriptState->name() : (securityOrigin ? securityOrigin->toRawString() : "");
+
     m_frontend->executionContextCreated(ExecutionContextDescription::create()
         .setId(executionContextId)
         .setIsPageContext(isPageContext)
         .setName(name)
         .setFrameId(frameId)
         .release());
 }
 
 } // namespace WebCore