Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: runtime/lib/string.cc

Issue 24975002: - Implement a first cut for const String.env in the VM to allow (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/integers_patch.dart ('k') | runtime/lib/string_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.cc
===================================================================
--- runtime/lib/string.cc (revision 28841)
+++ runtime/lib/string.cc (working copy)
@@ -4,7 +4,10 @@
#include "vm/bootstrap_natives.h"
+#include "include/dart_api.h"
#include "vm/exceptions.h"
+#include "vm/dart_api_impl.h"
+#include "vm/isolate.h"
#include "vm/native_entry.h"
#include "vm/object.h"
#include "vm/symbols.h"
@@ -12,6 +15,25 @@
namespace dart {
+DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) {
+ GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));
+ GET_NATIVE_ARGUMENT(String, default_value, arguments->NativeArgAt(2));
+ // Call the embedder to supply us with the environment.
+ Dart_EnvironmentCallback callback = isolate->environment_callback();
+ if (callback != NULL) {
+ Dart_Handle result = callback(kStringEnvironment,
+ Api::NewHandle(isolate, name.raw()));
+ if (!Dart_IsError(result)) {
+ const Object& value = Object::Handle(isolate, Api::UnwrapHandle(result));
+ if (value.IsString()) {
+ return Symbols::New(String::Cast(value));
+ }
+ }
+ }
+ return default_value.raw();
+}
+
+
DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Instance, list, arguments->NativeArgAt(0));
if (!list.IsGrowableObjectArray() && !list.IsArray()) {
« no previous file with comments | « runtime/lib/integers_patch.dart ('k') | runtime/lib/string_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698