Issue 24950002: Delete nag_max and nag_timer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24950002: Delete nag_max and nag_timer (Closed)

Created:
7 years, 2 months ago by scottmg

Modified:
7 years, 2 months ago

Reviewers:
iannucci, szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Delete nag_max and nag_timer It's impossible to sync by default on Windows and has been since this was added: https://www.google.com/search?q=chromium-dev+nag_max Most recently: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/CEpATyu9udc So, remove it. If someone needs it they can figure out a more targeted implementation. Keep --no-nag-max for backwards compat so that bot scripts won't fail out. I'll remove it from bot scripts after this has baked a while, and then come back and remove the option. R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225730

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -53 lines)			Patch
M	gclient.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	gclient_scm.py	View	7 chunks	+1 line, -17 lines	0 comments	Download
M	gclient_utils.py	View	5 chunks	+1 line, -23 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	5 chunks	+1 line, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

iannucci

lgtm. this 'feature' has caused nothing but grief, to my knowledge. I would definitely land ...

7 years, 2 months ago (2013-09-27 08:17:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/24950002/1

7 years, 2 months ago (2013-09-27 17:53:39 UTC) #3

Message was sent while issue was closed.

Change committed as 225730