Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 24863002: Revert 157959 "Introduce a new reference graph to SVG*TearOffs." (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index adbcecf26db46ebbbe4b9b7e286e9a665b364b3b..cb7ca0d1808d39d7cf79710884df85980aab6bda 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -819,7 +819,7 @@ public:
};
END
- my $customWrap = $interface->extendedAttributes->{"CustomToV8"} || SVGTypeNeedsToHoldContextElement($interface->name);
+ my $customWrap = $interface->extendedAttributes->{"CustomToV8"};
if ($noToV8) {
die "Can't suppress toV8 for subclass\n" if $interface->parent;
} elsif ($noWrap) {
@@ -4062,24 +4062,6 @@ v8::Handle<v8::Object> wrap($implClassName* impl, v8::Handle<v8::Object> creatio
END
}
- # Add strong reference from TearOff to SVGElement, so that SVGElement would never get GC-ed while the TearOff is alive. We do this in V8-side to avoid circular reference on Blink side.
- if (SVGTypeNeedsToHoldContextElement($interface->name)) {
- # below include needed for SVGPathSegListPropertyTearOff
- AddToImplIncludes("V8SVGPathElement.h");
- $implementation{nameSpaceWebCore}->add(<<END);
-v8::Handle<v8::Object> wrap($nativeType* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
- ASSERT(impl);
- ASSERT(!DOMDataStore::containsWrapper<${v8ClassName}>(impl, isolate));
- v8::Handle<v8::Object> wrapper = ${v8ClassName}::createWrapper(impl, creationContext, isolate);
- if (impl->contextElement())
- V8HiddenPropertyName::setNamedHiddenReference(wrapper, "contextElement", toV8(impl->contextElement(), creationContext, isolate));
- return wrapper;
-}
-
-END
- }
-
my @enabledPerContextFunctions;
my @normalFunctions;
my $needsDomainSafeFunctionSetter = 0;
@@ -5844,13 +5826,6 @@ sub IsSVGAnimatedType
return $type =~ /^SVGAnimated/;
}
-sub SVGTypeNeedsToHoldContextElement
-{
- my $type = shift;
-
- return IsSVGTypeNeedingTearOff($type) || IsSVGAnimatedType($type);
-}
-
sub GetSequenceType
{
my $type = shift;
« no previous file with comments | « LayoutTests/svg/dom/SVGListPropertyTearOff-leaks-expected.txt ('k') | Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698