Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 24863002: Revert 157959 "Introduce a new reference graph to SVG*TearOffs." (Closed)

Created:
7 years, 2 months ago by kouhei (in TOK)
Modified:
7 years, 2 months ago
Reviewers:
haraken, pdr., inferno
CC:
blink-reviews, shans, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, do-not-use, Nils Barth (inactive), Nate Chapin, alancutter (OOO until 2018), marja+watch_chromium.org, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, rjwright, darktears, haraken, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney
Visibility:
Public.

Description

Revert 157959 "Introduce a new reference graph to SVG*TearOffs." Revert 158014 "Hold onto contextElement() from SVGAnimated* wrap..." TBR=pdr@chromium.org,haraken@chromium.org BUG=270000 BUG=294464 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158408

Patch Set 1 #

Patch Set 2 : try 2 #

Patch Set 3 : try 3 #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -205 lines) Patch
D LayoutTests/svg/dom/SVGListPropertyTearOff-gccrash.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-gccrash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-leaks.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/svg/dom/SVGListPropertyTearOff-leaks-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 2 3 chunks +1 line, -26 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedListPropertyTearOff.h View 3 chunks +8 lines, -26 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 4 chunks +4 lines, -9 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.cpp View 1 chunk +6 lines, -25 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyTearOff.h View 7 chunks +4 lines, -24 lines 0 comments Download
M Source/core/svg/properties/SVGPathSegListPropertyTearOff.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGPropertyTearOff.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGStaticListPropertyTearOff.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
reverting this due to crbug.com/295725
7 years, 2 months ago (2013-09-26 22:11:37 UTC) #1
inferno
lgtm
7 years, 2 months ago (2013-09-26 22:12:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/24863002/1
7 years, 2 months ago (2013-09-26 22:15:33 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-26 22:15:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/24863002/7001
7 years, 2 months ago (2013-09-26 22:22:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-26 22:22:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/24863002/11001
7 years, 2 months ago (2013-09-26 22:40:54 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-26 22:41:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/24863002/16001
7 years, 2 months ago (2013-09-26 22:51:06 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 00:30:06 UTC) #10
Message was sent while issue was closed.
Change committed as 158408

Powered by Google App Engine
This is Rietveld 408576698