Issue 24846002: Always convert flag value to string in set_flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24846002: Always convert flag value to string in set_flag (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.

Modified:
7 years, 2 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Always convert flag value to string in set_flag The callee needs it to be a string so that it can be made part of HTTP request. However, in code using Rietveld it's useful to use non-string types for flags where Rietveld actually doesn't return strings (say booleans). One example is the commit flag, which is a boolean. BUG=291335 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225748

Patch Set 1 #

Patch Set 2 : re-upload #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	rietveld.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/24846002/8001

7 years, 2 months ago (2013-09-27 19:05:49 UTC) #4

Message was sent while issue was closed.

oops, belated lgtm

Expand Messages | Collapse Messages