Move file path functions into utils/file_path.py.

Move file path functions into utils/file_path.py.

These are useful functions by themselves.

R=vadimsh@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225565

[Vadim Sh., 2013-09-26 20:19:03]

lgtm

https://codereview.chromium.org/24813003/diff/1/utils/file_path.py
File utils/file_path.py (right):

https://codereview.chromium.org/24813003/diff/1/utils/file_path.py#newcode21
utils/file_path.py:21: import MacOS  # pylint: disable=F0401
I'm curious how does that gets into sys.path? Is it installed by default on
Macs?

[M-A Ruel, 2013-09-26 20:23:06]

https://codereview.chromium.org/24813003/diff/1/utils/file_path.py
File utils/file_path.py (right):

https://codereview.chromium.org/24813003/diff/1/utils/file_path.py#newcode21
utils/file_path.py:21: import MacOS  # pylint: disable=F0401
On 2013/09/26 20:19:03, Vadim Sh. wrote:
> I'm curious how does that gets into sys.path? Is it installed by default on
> Macs?

Yep.

[commit-bot: I haz the power, 2013-09-26 20:23:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/24813003/1

[commit-bot: I haz the power, 2013-09-26 20:24:23]

Presubmit check for 24813003-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py failed
........EEEEE.EEEEEEEEEEEEEEEEEEEEEEEEEEEE.EEEEEEEEE.EEEEEE
======================================================================
ERROR: test_all_items_invalid (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 542, in test_all_items_invalid
    out = self._test_all_items_invalid('archive')
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 392, in _test_all_items_invalid
    self._expect_results(['empty.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_fail (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 533, in test_fail
    self._expect_results(['fail.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_missing_trailing_slash (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 536, in test_missing_trailing_slash
    self._test_missing_trailing_slash('archive')
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 364, in _test_missing_trailing_slash
    root = isolate.trace_inputs.get_native_path_case(unicode(ROOT_DIR))
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_no_run (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 552, in test_no_run
    self._expect_results([], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_non_existent (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 539, in test_non_existent
    self._test_non_existent('archive')
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 381, in _test_non_existent
    root = isolate.trace_inputs.get_native_path_case(unicode(ROOT_DIR))
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_symlink_full (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 635, in test_symlink_full
    self._expect_results(['symlink_full.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_symlink_outside_build_root (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 658, in test_symlink_outside_build_root
    self._expect_results(['symlink_outside_build_root.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_symlink_partial (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 646, in test_symlink_partial
    self._expect_results(['symlink_partial.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_touch_root (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 616, in test_touch_root
    self._expect_results(['touch_root.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_with_flag (__main__.Isolate_archive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 623, in test_with_flag
    ['with_flag.py', 'gyp'], None, {u'FLAG': u'gyp'}, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_all_items_invalid (__main__.Isolate_check)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 470, in test_all_items_invalid
    out = self._test_all_items_invalid('check')
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 392, in _test_all_items_invalid
    self._expect_results(['empty.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 285, in _expect_results
    self._expected_saved_state(args, read_only, empty_file, extra_vars)
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 268, in _expected_saved_state
    isolate.trace_inputs.get_native_path_case(unicode(self.filename())),
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_fail (__main__.Isolate_check)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/swarm_client/tests/isolate_smoke_test.py",
line 461, in test_fail
    self._expect_results(['fail.py'], None, None, None)
  File "/b/commit-queue/workdir/tools/swarm_client/tests…
(message too large)

[commit-bot: I haz the power, 2013-09-26 20:35:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/24813003/10001

[commit-bot: I haz the power, 2013-09-26 20:36:47]

Presubmit check for 24813003-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py
failed
EEEEEEEEEEE
======================================================================
ERROR: test_trace (__main__.TraceInputs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_json (__main__.TraceInputs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_multiple (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_quoted (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_symlink (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_touch_only_access (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_touch_only_isfile (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_touch_only_stat (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_tricky_filename (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

======================================================================
ERROR: test_trace_wrong_path (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/trace_inputs_smoke_test.py",
line 75, in setUp
    self.real_executable = trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

----------------------------------------------------------------------
Ran 11 tests in 0.002s

FAILED (errors=11)


/b/commit-queue/workdir/tools/swarm_client/googletest/tests/isolate_test_cases_smoke_test.py
failed
E
======================================================================
ERROR: test_simple (__main__.IsolateTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/isolate_test_cases_smoke_test.py",
line 47, in setUp
    self.real_executable = isolate.trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)


Presubmit checks took 69.2s to calculate.

[commit-bot: I haz the power, 2013-09-26 20:38:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/24813003/14001

[commit-bot: I haz the power, 2013-09-26 20:40:34]

Presubmit check for 24813003-14001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
/b/commit-queue/workdir/tools/swarm_client/googletest/tests/isolate_test_cases_smoke_test.py
failed
E
======================================================================
ERROR: test_simple (__main__.IsolateTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/isolate_test_cases_smoke_test.py",
line 47, in setUp
    self.real_executable = isolate.trace_inputs.get_native_path_case(
AttributeError: 'module' object has no attribute 'get_native_path_case'

----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)


Presubmit checks took 89.6s to calculate.

[commit-bot: I haz the power, 2013-09-26 21:06:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/24813003/22001

[commit-bot: I haz the power, 2013-09-26 21:08:09]

Change committed as 225565