Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 24751003: GrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig. (Closed)

Created:
7 years, 2 months ago by jvanverth1
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

GrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig. This gets the font-specific GrMaskFormat out of GrAtlas and replaces it with more generic configs, allowing GrAtlas to be used for other things. Committed: http://code.google.com/p/skia/source/detail?r=11474

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits. #

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M src/gpu/GrAtlas.h View 5 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 7 chunks +13 lines, -27 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvanverth1
7 years, 2 months ago (2013-09-26 13:28:50 UTC) #1
robertphillips
lgtm + 2 nits/suggestions https://codereview.chromium.org/24751003/diff/1/src/gpu/GrAtlas.cpp File src/gpu/GrAtlas.cpp (right): https://codereview.chromium.org/24751003/diff/1/src/gpu/GrAtlas.cpp#newcode125 src/gpu/GrAtlas.cpp:125: if (BORDER) { Replace bpp ...
7 years, 2 months ago (2013-09-26 13:47:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/24751003/8001
7 years, 2 months ago (2013-09-26 15:15:10 UTC) #3
jvanverth1
https://codereview.chromium.org/24751003/diff/1/src/gpu/GrAtlas.cpp File src/gpu/GrAtlas.cpp (right): https://codereview.chromium.org/24751003/diff/1/src/gpu/GrAtlas.cpp#newcode125 src/gpu/GrAtlas.cpp:125: if (BORDER) { On 2013/09/26 13:47:35, robertphillips wrote: > ...
7 years, 2 months ago (2013-09-26 15:16:07 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 15:28:45 UTC) #5
Message was sent while issue was closed.
Change committed as 11474

Powered by Google App Engine
This is Rietveld 408576698