Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/polymer.py

Issue 24737002: Add Paths as first-class types in configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json ('K') | « scripts/slave/recipes/gpu.py ('k') | scripts/slave/unittests/recipe_configs_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/polymer.py
diff --git a/scripts/slave/recipes/polymer.py b/scripts/slave/recipes/polymer.py
index a41f42c3e1868dc8f804ca137ffd0afa637d4c9f..b710b5f90de1ec19e0062b7a390f8631ee81e598 100644
--- a/scripts/slave/recipes/polymer.py
+++ b/scripts/slave/recipes/polymer.py
@@ -52,10 +52,9 @@ def _CheckoutSteps(api):
def GenSteps(api):
-
yield _CheckoutSteps(api)
this_repo = api.properties['buildername'].split()[0]
- api.path.choose_checkout(api.path.slave_build(this_repo))
+ api.path.set_dynamic_path('checkout', api.path.slave_build(this_repo))
tmp_path = ''
tmp_args = []
@@ -87,10 +86,10 @@ def GenSteps(api):
test_prefix = ['xvfb-run']
yield api.step('update-install', ['npm' + cmd_suffix, 'install'] + tmp_args,
- cwd=api.path.checkout(), env=node_env)
+ cwd=api.path.checkout, env=node_env)
yield api.step('test', test_prefix + ['grunt' + cmd_suffix,
- 'test-buildbot'], cwd=api.path.checkout(),
+ 'test-buildbot'], cwd=api.path.checkout,
env=node_env, allow_subannotations=True)
« scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json ('K') | « scripts/slave/recipes/gpu.py ('k') | scripts/slave/unittests/recipe_configs_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698