Add Paths as first-class types in configs.

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 class ChromiumApi(recipe_api.RecipeApi):
   def get_config_defaults(self):
     return {
       'HOST_PLATFORM': self.m.platform.name,
@@ skipping 10 matching lines @@
       'BUILD_CONFIG': self.m.properties.get('build_config', 'Release')
     }
 
   def compile(self, targets=None, name=None, **kwargs):
     """Return a compile.py invocation."""
     targets = targets or self.c.compile_py.default_targets.as_jsonish()
     assert isinstance(targets, (list, tuple))
 
     args = [
       '--target', self.c.build_config_fs,
-      '--build-dir', self.m.path.checkout(self.c.build_dir),
-      '--src-dir', self.m.path.checkout(),
+      '--build-dir', self.c.build_dir,
+      '--src-dir', self.m.path.checkout,

[agable, 2013/09/26 21:46:02]

Did you find/replace for all instances of {m.path|api.path}.[path_method]() to
remove the empty parentheses? Just want to make sure they're really all gone.

[iannucci, 2013/09/27 02:08:20]

I didn't, just the ones I saw... it actually doesn't end up making a difference
in the new system though. I found and killed the stragglers.

[agable, 2013/09/27 17:48:16]

Thanks. I just wanted to make sure we weren't sending mixed messages for proper
style when you're not adding any new tokens to the path.

     ]
     if self.c.compile_py.build_tool:
       args += ['--build-tool', self.c.compile_py.build_tool]
     if self.c.compile_py.compiler:
       args += ['--compiler', self.c.compile_py.compiler]
     if self.m.properties.get('clobber') is not None:
       args.append('--clobber')
     args.append('--')
     args.extend(targets)
     return self.m.python(name or 'compile',
                          self.m.path.build('scripts', 'slave', 'compile.py'),
                          args, abort_on_failure=True, **kwargs)
 
   def runtests(self, test, args=None, xvfb=False, name=None, annotate=None,
                results_url=None, perf_dashboard_id=None, test_type=None,
                generate_json_file=False, results_directory=None,
                build_number=None, builder_name=None, **kwargs):
     """Return a runtest.py invocation."""
     args = args or []
     assert isinstance(args, list)
 
     t_name, ext = self.m.path.splitext(self.m.path.basename(test))
     if self.m.platform.is_win and ext == '':
       test += '.exe'
 
     full_args = [
       '--target', self.c.build_config_fs,
-      '--build-dir', self.m.path.checkout(self.c.build_dir),
+      '--build-dir', self.c.build_dir,
       ('--xvfb' if xvfb else '--no-xvfb')
     ]
     full_args += self.m.json.property_args()
 
     if annotate:
       full_args.append('--annotate=%s' % annotate)
       kwargs['allow_subannotations'] = True
     if results_url:
       full_args.append('--results-url=%s' % results_url)
     if perf_dashboard_id:
@@ skipping 24 matching lines @@
       **kwargs
     )
 
   def runhooks(self, **kwargs):
     """Run the build-configuration hooks for chromium."""
     env = kwargs.get('env', {})
     env.update(self.c.gyp_env.as_jsonish())
     kwargs['env'] = env
     return self.m.gclient.runhooks(**kwargs)