Split feature definitions into extensions and chrome features.

extensions/common/extensions_client.h

Index: extensions/common/extensions_client.h
diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h
index e9fb2005d02ae59ca3a7a1479081b2e38e57ccfb..cb1c3b08a7b882346d8098f91d9fc663d6cb0d46 100644
--- a/extensions/common/extensions_client.h
+++ b/extensions/common/extensions_client.h
@@ -46,9 +46,10 @@ class ExtensionsClient {
   virtual const PermissionMessageProvider& GetPermissionMessageProvider()
       const = 0;
 
-  // Gets a feature provider for a specific feature type.
-  virtual FeatureProvider* GetFeatureProviderByName(const std::string& name)
-      const = 0;
+  // Create a FeatureProvider for a specific feature type, e.g. "permission".
+  // The caller takes ownership of the FeatureProvider.
+  virtual FeatureProvider* CreateFeatureProvider(
+      const std::string& name) const = 0;
 
   // Takes the list of all hosts and filters out those with special
   // permission strings. Adds the regular hosts to |new_hosts|,
@@ -80,9 +81,6 @@ class ExtensionsClient {
   // Gets the API schema named |name|.
   virtual base::StringPiece GetAPISchema(const std::string& name) const = 0;
 
-  // Appends extra filters to any Features created by the features system.
-  virtual void AddExtraFeatureFilters(SimpleFeature* feature) const = 0;
-
   // Determines if certain fatal extensions errors should be surpressed
   // (i.e., only logged) or allowed (i.e., logged before crashing).
   virtual bool ShouldSuppressFatalErrors() const = 0;