apps/shell/common/shell_extensions_client.h - Issue 246423002: Split feature definitions into extensions and chrome features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/shell/common/shell_extensions_client.h

Issue 246423002: Split feature definitions into extensions and chrome features. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: + Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/shell/common/shell_extensions_client.h

diff --git a/apps/shell/common/shell_extensions_client.h b/apps/shell/common/shell_extensions_client.h

index e920b38c2a803341ea19f9f50409f51e4d5d4ec9..d1caef4437f9ba1221798d8d53bed951f04a14c4 100644

--- a/apps/shell/common/shell_extensions_client.h

+++ b/apps/shell/common/shell_extensions_client.h

@@ -23,7 +23,7 @@ class ShellExtensionsClient : public extensions::ExtensionsClient {

OVERRIDE;

virtual const extensions::PermissionMessageProvider&

GetPermissionMessageProvider() const OVERRIDE;

- virtual extensions::FeatureProvider* GetFeatureProviderByName(

+ virtual extensions::FeatureProvider* CreateFeatureProvider(

const std::string& name) const OVERRIDE;

virtual void FilterHostPermissions(

const extensions::URLPatternSet& hosts,

@@ -40,8 +40,6 @@ class ShellExtensionsClient : public extensions::ExtensionsClient {

virtual bool IsAPISchemaGenerated(const std::string& name) const OVERRIDE;

virtual base::StringPiece GetAPISchema(const std::string& name) const

OVERRIDE;

- virtual void AddExtraFeatureFilters(extensions::SimpleFeature* feature) const

- OVERRIDE;

virtual bool ShouldSuppressFatalErrors() const OVERRIDE;

private: