Split feature definitions into extensions and chrome features.

extensions/common/features/feature_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/feature_provider.h"
 
+#include <map>
+
 #include "base/basictypes.h"
+#include "base/lazy_instance.h"
+#include "base/memory/linked_ptr.h"
 #include "extensions/common/extensions_client.h"
 
 namespace extensions {
 
+namespace {
+
+struct Static {

[not at google - send to devlin, 2014/04/22 21:39:09]

this seems more like a class, and |feature_providers| should be a private
|feature_providers_| variable.

[Yoyo Zhou, 2014/04/22 23:17:40]

Done.

+  Static() {
+    ExtensionsClient* client = ExtensionsClient::Get();
+    feature_providers["api"] =
+        make_linked_ptr(client->CreateFeatureProvider("api"));
+    feature_providers["manifest"] =
+        make_linked_ptr(client->CreateFeatureProvider("manifest"));
+    feature_providers["permission"] =
+        make_linked_ptr(client->CreateFeatureProvider("permission"));
+  }
+
+  typedef std::map<std::string, linked_ptr<FeatureProvider> >
+      FeatureProviderMap;
+
+  FeatureProvider* GetFeatures(const std::string& name) const {
+    FeatureProviderMap::const_iterator it = feature_providers.find(name);
+    CHECK(it != feature_providers.end());
+    return it->second.get();
+  }
+
+  FeatureProviderMap feature_providers;
+};
+
+base::LazyInstance<Static> g_static = LAZY_INSTANCE_INITIALIZER;
+
+}  // namespace
+
 // static
 FeatureProvider* FeatureProvider::GetByName(const std::string& name) {
-  return ExtensionsClient::Get()->GetFeatureProviderByName(name);
+  return g_static.Get().GetFeatures(name);
 }
 
 // static
 FeatureProvider* FeatureProvider::GetAPIFeatures() {
   return GetByName("api");
 }
 
 // static
 FeatureProvider* FeatureProvider::GetManifestFeatures() {
   return GetByName("manifest");
 }
 
 // static
 FeatureProvider* FeatureProvider::GetPermissionFeatures() {
   return GetByName("permission");
 }
 
 }  // namespace extensions