Split feature definitions into extensions and chrome features.

extensions/common/extensions_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSIONS_CLIENT_H_
 #define EXTENSIONS_COMMON_EXTENSIONS_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 28 matching lines @@
   virtual void Initialize() = 0;
 
   // Returns a PermissionsProvider to initialize the permissions system.
   virtual const PermissionsProvider& GetPermissionsProvider() const = 0;
 
   // Returns the global PermissionMessageProvider to use to provide permission
   // warning strings.
   virtual const PermissionMessageProvider& GetPermissionMessageProvider()
       const = 0;
 
-  // Gets a feature provider for a specific feature type.
-  virtual FeatureProvider* GetFeatureProviderByName(const std::string& name)
-      const = 0;
+  // Create a FeatureProvider for a specific feature type, e.g. "permission".
+  // The caller takes ownership of the FeatureProvider.
+  virtual FeatureProvider* CreateFeatureProvider(
+      const std::string& name) const = 0;
 
   // Takes the list of all hosts and filters out those with special
   // permission strings. Adds the regular hosts to |new_hosts|,
   // and adds the special permission messages to |messages|.
   virtual void FilterHostPermissions(
       const URLPatternSet& hosts,
       URLPatternSet* new_hosts,
       std::set<PermissionMessage>* messages) const = 0;
 
   // Replaces the scripting whitelist with |whitelist|. Used in the renderer;
@@ skipping 11 matching lines @@
 
   // Returns false if content scripts are forbidden from running on |url|.
   virtual bool IsScriptableURL(const GURL& url, std::string* error) const = 0;
 
   // Returns true iff a schema named |name| is generated.
   virtual bool IsAPISchemaGenerated(const std::string& name) const = 0;
 
   // Gets the API schema named |name|.
   virtual base::StringPiece GetAPISchema(const std::string& name) const = 0;
 
-  // Appends extra filters to any Features created by the features system.
-  virtual void AddExtraFeatureFilters(SimpleFeature* feature) const = 0;
-
   // Determines if certain fatal extensions errors should be surpressed
   // (i.e., only logged) or allowed (i.e., logged before crashing).
   virtual bool ShouldSuppressFatalErrors() const = 0;
 
   // Return the extensions client.
   static ExtensionsClient* Get();
 
   // Initialize the extensions system with this extensions client.
   static void Set(ExtensionsClient* client);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSIONS_CLIENT_H_