Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: extensions/common/features/base_feature_provider.h

Issue 246423002: Split feature definitions into extensions and chrome features. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: repack2 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 5 #ifndef EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
6 #define EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 6 #define EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/memory/linked_ptr.h" 12 #include "base/memory/linked_ptr.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "extensions/common/features/feature_provider.h" 14 #include "extensions/common/features/feature_provider.h"
15 #include "extensions/common/features/simple_feature.h" 15 #include "extensions/common/features/simple_feature.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 // Reads Features out of a simple JSON file description. 19 // Reads Features out of a simple JSON file description.
20 class BaseFeatureProvider : public FeatureProvider { 20 class BaseFeatureProvider : public FeatureProvider {
21 public: 21 public:
22 typedef SimpleFeature*(*FeatureFactory)(); 22 typedef SimpleFeature*(*FeatureFactory)();
23 23
24 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the 24 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the
25 // provider create plain old Feature instances. 25 // provider create plain old Feature instances.
26 BaseFeatureProvider(const base::DictionaryValue& root, 26 BaseFeatureProvider(const base::DictionaryValue& root,
27 FeatureFactory factory); 27 FeatureFactory factory);
28 virtual ~BaseFeatureProvider(); 28 virtual ~BaseFeatureProvider();
29 29
30 // Gets a feature provider for a specific feature type, like "permission".
31 static FeatureProvider* GetByName(const std::string& name);
32
33 // Gets the feature |feature_name|, if it exists. 30 // Gets the feature |feature_name|, if it exists.
34 virtual Feature* GetFeature(const std::string& feature_name) const OVERRIDE; 31 virtual Feature* GetFeature(const std::string& feature_name) const OVERRIDE;
35 virtual Feature* GetParent(Feature* feature) const OVERRIDE; 32 virtual Feature* GetParent(Feature* feature) const OVERRIDE;
36 virtual std::vector<Feature*> GetChildren(const Feature& parent) const 33 virtual std::vector<Feature*> GetChildren(const Feature& parent) const
37 OVERRIDE; 34 OVERRIDE;
38 35
39 virtual const std::vector<std::string>& GetAllFeatureNames() const OVERRIDE; 36 virtual const std::vector<std::string>& GetAllFeatureNames() const OVERRIDE;
40 37
41 private: 38 private:
42 typedef std::map<std::string, linked_ptr<Feature> > FeatureMap; 39 typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
43 FeatureMap features_; 40 FeatureMap features_;
44 41
45 // Populated on first use. 42 // Populated on first use.
46 mutable std::vector<std::string> feature_names_; 43 mutable std::vector<std::string> feature_names_;
47 44
48 FeatureFactory factory_; 45 FeatureFactory factory_;
49 }; 46 };
50 47
51 } // namespace extensions 48 } // namespace extensions
52 49
53 #endif // EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 50 #endif // EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
OLDNEW
« no previous file with comments | « extensions/common/extensions_client.h ('k') | extensions/common/features/base_feature_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698