Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 24641003: Implement Promise.all (Closed)

Created:
7 years, 2 months ago by yusukesuzuki
Modified:
7 years, 2 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement Promise.all Implement Promise.all static function. It is introduced in the Promises latest draft and Promise.every is replaced with it. BUG=295420 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158412

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -129 lines) Patch
M LayoutTests/crypto/resources/common.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-video.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-recursive.html View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-all.html View 1 chunk +105 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-all-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
D LayoutTests/fast/js/Promise-static-every.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/fast/js/Promise-static-every-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 5 chunks +34 lines, -24 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
yusukesuzuki
7 years, 2 months ago (2013-09-26 10:54:26 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-09-26 18:07:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/24641003/4001
7 years, 2 months ago (2013-09-26 18:07:12 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Promise.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-26 19:13:53 UTC) #4
yusukesuzuki
Thanks, I'll fix the conflict with Promise.race patch.
7 years, 2 months ago (2013-09-27 00:04:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/24641003/16001
7 years, 2 months ago (2013-09-27 00:13:44 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-09-27 02:20:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/24641003/16001
7 years, 2 months ago (2013-09-27 02:21:34 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 02:22:15 UTC) #9
Message was sent while issue was closed.
Change committed as 158412

Powered by Google App Engine
This is Rietveld 408576698