Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2682)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 24631003: Add proper API for creating private symbols wrt a library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: amend tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index e977653737ec927ca00664846cd12ad8100d683a..45dc8bd4c5cacb4ad96c55ec26d00607f1493abc 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -289,7 +289,7 @@ class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
_LocalInstanceMirrorImpl mirror =
reflect(invocation);
_invokeOnClosure = reflectClass(invocation.runtimeType)
- .getField(const Symbol('_invokeOnClosure')).reflectee;
+ .getField(MirrorSystem.getSymbol('_invokeOnClosure', mirror.type.owner)).reflectee;
}
return _invokeOnClosure(reflectee, invocation);
}
@@ -634,7 +634,7 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl
}
}
- String toString() => "ClassMirror on '${_n(simpleName)}'";
+ String toString() => "ClassMirror on '${MirrorSystem.getName(simpleName)}'";
InstanceMirror newInstance(Symbol constructorName,
List positionalArguments,
@@ -1117,7 +1117,7 @@ class _LocalMethodMirrorImpl extends _LocalDeclarationMirrorImpl
}
}
- String toString() => "MethodMirror on '${_n(simpleName)}'";
+ String toString() => "MethodMirror on '${MirrorSystem.getName(simpleName)}'";
static dynamic _MethodMirror_owner(reflectee)
native "MethodMirror_owner";
@@ -1162,7 +1162,7 @@ class _LocalVariableMirrorImpl extends _LocalDeclarationMirrorImpl
return _type;
}
- String toString() => "VariableMirror on '${_n(simpleName)}'";
+ String toString() => "VariableMirror on '${MirrorSystem.getName(simpleName)}'";
static _VariableMirror_type(reflectee)
native "VariableMirror_type";
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/lib/mirrors_patch.dart » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698