Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 24631003: Add proper API for creating private symbols wrt a library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/mirrors/mirrors.dart
diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart
index 0b9ebe52901ad6e493209ce56976a73721e9e9c7..6e21e388ef369ccbb863ef6ebf59bfff5ce70dfa 100644
--- a/sdk/lib/mirrors/mirrors.dart
+++ b/sdk/lib/mirrors/mirrors.dart
@@ -104,6 +104,17 @@ abstract class MirrorSystem {
* [MirrorsUsed] to specify which symbols must be retained in clear text.
*/
external static String getName(Symbol symbol);
+
+ /**
+ * Returns a symbol for [name]. If [name] is a private identifier, the symbol
+ * returned is with respect to [lib].
ahe 2013/10/11 10:27:15 What happens if name is a private identifier and l
rmacnak 2013/10/11 20:39:33 Specified ArgumentError.
+ *
+ * The following text is non-normative:
+ *
+ * Using this method may result in larger output. If possible, use
+ * the const constructor of Symbol or symbol literals.
+ */
+ external static Symbol getSymbol(String name, [LibraryMirror lib]);
ahe 2013/10/11 10:27:15 Change from "lib" to "library" (don't abbreviate).
rmacnak 2013/10/11 20:39:33 Done.
}
/**

Powered by Google App Engine
This is Rietveld 408576698