Add proper API for creating private symbols wrt a library.

runtime/tests/vm/dart/isolate_mirror_local_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for checking implemention of MirrorSystem when
 // inspecting the current isolate.
 //
 // VMOptions=--enable_type_checks
 
 library isolate_mirror_local_test;
@@ skipping 106 matching lines @@
   Expect.isFalse(lib_mirror.isPrivate);
   Expect.isTrue(lib_mirror.uri.path.contains('isolate_mirror_local_test.dart'));
   Expect.equals("LibraryMirror on 'isolate_mirror_local_test'",
                 lib_mirror.toString());
 
   // Test library invocation by calling function(123).
   Expect.equals(0, global_var);
   lib_mirror.invokeAsync(const Symbol('function'), [123]).then(
       (InstanceMirror retval) {
         Expect.equals(123, global_var);
-        Expect.equals(const Symbol('int'), retval.type.simpleName);
+        testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(124, retval.reflectee);
         testDone('testRootLibraryMirror');
       });
 
   // Check that the members map is complete.
   List keys = lib_mirror.members.keys.map(MirrorSystem.getName).toList();
   sort(keys);
   Expect.equals('['
                 'FuncType, '
@@ skipping 13 matching lines @@
                 'main, '
                 'methodWithError, '
                 'methodWithException, '
                 'myFunc, '
                 'myVar, '
                 'myVar=, '
                 'sort, '
                 'testBoolInstanceMirror, '
                 'testCustomInstanceMirror, '
                 'testDone, '
+                'testImplements, '
                 'testIntegerInstanceMirror, '
                 'testLibrariesMap, '
                 'testMirrorErrors, '
                 'testMirrorSystem, '
                 'testNullInstanceMirror, '
                 'testRootLibraryMirror, '
                 'testStringInstanceMirror]',
                 '$keys');
 
   // Check that the classes map is complete.
@@ skipping 18 matching lines @@
                 'function, '
                 'main, '
                 'methodWithError, '
                 'methodWithException, '
                 'myVar, '
                 'myVar=, '
                 'sort, '
                 'testBoolInstanceMirror, '
                 'testCustomInstanceMirror, '
                 'testDone, '
+                'testImplements, '
                 'testIntegerInstanceMirror, '
                 'testLibrariesMap, '
                 'testMirrorErrors, '
                 'testMirrorSystem, '
                 'testNullInstanceMirror, '
                 'testRootLibraryMirror, '
                 'testStringInstanceMirror]',
                 '$keys');
 
   // Check that the getters map is complete.
@@ skipping 132 matching lines @@
   testLibrariesMap(mirrors.libraries);
   Expect.equals(const Symbol('void'), mirrors.voidType.simpleName);
   Expect.equals(const Symbol('dynamic'), mirrors.dynamicType.simpleName);
   Expect.isTrue(mirrors.voidType is TypeMirror);
   Expect.isTrue(mirrors.dynamicType is TypeMirror);
   Expect.isFalse(mirrors.voidType is ClassMirror);
   Expect.isFalse(mirrors.dynamicType is ClassMirror);
   testDone('testMirrorSystem');
 }
 
+void testImplements(klass, intfName) {
+  bool foundInterface = false;
+  for (ClassMirror cm = klass; cm != null; cm = cm.superclass) {
+    if (cm.simpleName == intfName) foundInterface = true;
+    cm.superinterfaces.forEach((intf) {
+      if (intf.simpleName == intfName) foundInterface = true;
+    });
+  }
+  Expect.isTrue(foundInterface, '$klass should implement $intfName');
+}
+
 void testIntegerInstanceMirror(InstanceMirror mirror) {
-  Expect.equals(const Symbol('int'), mirror.type.simpleName);
+  testImplements(mirror.type, #int);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals(1001, mirror.reflectee);
   Expect.equals("InstanceMirror on 1001", mirror.toString());
 
   // Invoke (mirror + mirror).
   mirror.invokeAsync(const Symbol('+'), [ mirror ]).then(
       (InstanceMirror retval) {
-        Expect.equals(const Symbol('int'), retval.type.simpleName);
+        testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(2002, retval.reflectee);
         testDone('testIntegerInstanceMirror');
       });
 }
 
 void testStringInstanceMirror(InstanceMirror mirror) {
-  Expect.equals(const Symbol('String'), mirror.type.simpleName);
+  testImplements(mirror.type, #String);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals('This\nis\na\nString', mirror.reflectee);
   Expect.equals('InstanceMirror on "This\\nis\\na\\nString"',
                 mirror.toString());
 
   // Invoke mirror[0].
   mirror.invokeAsync(const Symbol('[]'), [ 0 ]).then(
       (InstanceMirror retval) {
-        Expect.equals(const Symbol('String'), retval.type.simpleName);
+        testImplements(retval.type, #String);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals('T', retval.reflectee);
         testDone('testStringInstanceMirror');
       });
 }
 
 void testBoolInstanceMirror(InstanceMirror mirror) {
-  Expect.equals(const Symbol('bool'), mirror.type.simpleName);
+  testImplements(mirror.type, #bool);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals(true, mirror.reflectee);
   Expect.equals("InstanceMirror on true", mirror.toString());
   testDone('testBoolInstanceMirror');
 }
 
 void testNullInstanceMirror(InstanceMirror mirror) {
-  Expect.equals(const Symbol('Null'), mirror.type.simpleName);
+  testImplements(mirror.type, #Null);
   Expect.isTrue(mirror.hasReflectee);
   Expect.equals(null, mirror.reflectee);
   Expect.equals("InstanceMirror on null", mirror.toString());
   testDone('testNullInstanceMirror');
 }
 
 class MySuperClass {
 }
 
 class MyInterface {
@@ skipping 39 matching lines @@
   Expect.isTrue(cls.isClass);
   Expect.equals(const Symbol('MyInterface'), cls.superinterfaces[0].simpleName);
   Expect.throws(() => cls.metadata,
                 (e) => e is MirroredCompilationError,
                 'Bad metadata');
   Expect.equals("ClassMirror on 'MyClass'", cls.toString());
 
   // Invoke mirror.method(1000).
   mirror.invokeAsync(const Symbol('method'), [ 1000 ]).then(
       (InstanceMirror retval) {
-        Expect.equals(const Symbol('int'), retval.type.simpleName);
+        testImplements(retval.type, #int);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(1017, retval.reflectee);
         testDone('testCustomInstanceMirror');
       });
 
 }
 
 class MyException implements Exception {
   MyException(this._message);
   final String _message;
@@ skipping 70 matching lines @@
   // Test that an isolate can reflect on itself.
   mirrorSystemOf(exit_port.toSendPort()).then(testMirrorSystem);
 
   testIntegerInstanceMirror(reflect(1001));
   testStringInstanceMirror(reflect('This\nis\na\nString'));
   testBoolInstanceMirror(reflect(true));
   testNullInstanceMirror(reflect(null));
   testCustomInstanceMirror(reflect(new MyClass(17)));
   testMirrorErrors(currentMirrorSystem());
 }