Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 24608002: First pass at font cache refactor: Create an atlas manager per texture (Closed)

Created:
7 years, 2 months ago by jvanverth1
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

First pass at font cache refactor: Create an atlas manager per texture This changes the AtlasMgr from a singleton class to one that is created per-texture. This is the first step in allowing us to create Atlases of other types (e.g., combine small icons into one big texture). Committed: http://code.google.com/p/skia/source/detail?r=11468

Patch Set 1 #

Patch Set 2 : Make sure to set the MaskFormat #

Patch Set 3 : Make sure to set the MaskFormat #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M include/gpu/GrTypes.h View 1 chunk +3 lines, -2 lines 2 comments Download
M src/gpu/GrAtlas.h View 1 chunk +9 lines, -10 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 6 chunks +17 lines, -27 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextStrike.cpp View 4 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvanverth1
7 years, 2 months ago (2013-09-25 16:46:52 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/24608002/diff/5001/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/24608002/diff/5001/include/gpu/GrTypes.h#newcode247 include/gpu/GrTypes.h:247: enum GrMaskFormat { Not for this CL, but ...
7 years, 2 months ago (2013-09-25 16:51:39 UTC) #2
jvanverth1
https://codereview.chromium.org/24608002/diff/5001/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/24608002/diff/5001/include/gpu/GrTypes.h#newcode247 include/gpu/GrTypes.h:247: enum GrMaskFormat { On 2013/09/25 16:51:39, bsalomon wrote: > ...
7 years, 2 months ago (2013-09-25 16:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/24608002/5001
7 years, 2 months ago (2013-09-26 12:51:28 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 12:57:24 UTC) #5
Message was sent while issue was closed.
Change committed as 11468

Powered by Google App Engine
This is Rietveld 408576698