Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 246073008: Roll grit r167. (Closed)

Created:
6 years, 8 months ago by Peter Lundblad
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Roll grit r167. Changes: - List removed (non-whitelisted) resources when repacking. - Speed-up whitelist check in data_pack.py - Fix leading/trailing whitespace in chrome_extension_json output. - Make grit aware that nb and no language codes are equivalent. BUG=364961 R=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265500

Patch Set 1 #

Patch Set 2 : 167 also wanted to roll... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Lundblad
6 years, 8 months ago (2014-04-22 20:48:54 UTC) #1
aurimas (slooooooooow)
LGTM.
6 years, 8 months ago (2014-04-22 20:53:48 UTC) #2
aurimas (slooooooooow)
Actually, quick question: we are rolling 6 revisions, but it only list 3 changes in ...
6 years, 8 months ago (2014-04-22 20:55:07 UTC) #3
aurimas (slooooooooow)
On 2014/04/22 20:55:07, aurimas wrote: > Actually, quick question: we are rolling 6 revisions, but ...
6 years, 8 months ago (2014-04-22 20:56:35 UTC) #4
Peter Lundblad
aurimas@chromium.org writes: > On 2014/04/22 20:55:07, aurimas wrote: > > Actually, quick question: we are ...
6 years, 8 months ago (2014-04-22 21:11:45 UTC) #5
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 8 months ago (2014-04-22 21:22:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/246073008/20001
6 years, 8 months ago (2014-04-22 21:23:21 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 02:17:33 UTC) #8
Message was sent while issue was closed.
Change committed as 265500

Powered by Google App Engine
This is Rietveld 408576698