Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 24569002: Do not beep on failed copy/cut. (Closed)

Created:
7 years, 2 months ago by pwnall-personal
Modified:
7 years, 2 months ago
CC:
blink-reviews, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not beep on failed copy/cut. WebCore::systemBeep() is only used by WebCore::Editor and WebCore::EditorCommand, so we silence it. BUG=36963 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158534

Patch Set 1 #

Patch Set 2 : Feedback from jochen #

Patch Set 3 : Removed Sound from code/platform altogether #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -139 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 4 chunks +3 lines, -12 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 3 chunks +2 lines, -7 lines 0 comments Download
D Source/core/platform/Sound.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/platform/chromium/SoundChromiumPosix.cpp View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
M Source/core/platform/chromium/SoundChromiumWin.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pwnall-personal
I looked into http://crbug.com/36963 and solved it according to the comments in the bug. Can ...
7 years, 2 months ago (2013-09-25 11:58:35 UTC) #1
jochen (gone - plz use gerrit)
I think it's preferable to also remove all callsites
7 years, 2 months ago (2013-09-26 20:30:01 UTC) #2
pwnall-personal
Thank you for the quick feedback, and sorry it took a while to turn this ...
7 years, 2 months ago (2013-09-28 00:02:25 UTC) #3
jochen (gone - plz use gerrit)
On 2013/09/28 00:02:25, pwnall wrote: > Thank you for the quick feedback, and sorry it ...
7 years, 2 months ago (2013-09-30 10:00:42 UTC) #4
pwnall-personal
On 2013/09/30 10:00:42, jochen wrote: > On 2013/09/28 00:02:25, pwnall wrote: > > Thank you ...
7 years, 2 months ago (2013-09-30 10:55:45 UTC) #5
jochen (gone - plz use gerrit)
lgtm, thanks!
7 years, 2 months ago (2013-09-30 11:07:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/24569002/10001
7 years, 2 months ago (2013-09-30 11:54:34 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 12:48:18 UTC) #8
Message was sent while issue was closed.
Change committed as 158534

Powered by Google App Engine
This is Rietveld 408576698