Issue 24566005: Internalize names before using them in slow-mode objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24566005: Internalize names before using them in slow-mode objects. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest

Modified:
7 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Internalize names before using them in slow-mode objects. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16944

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	src/bootstrapper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+13 lines, -0 lines	1 comment	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

lgtm. https://chromiumcodereview.appspot.com/24566005/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/24566005/diff/1/src/objects.cc#newcode687 src/objects.cc:687: stray edit.

7 years, 2 months ago (2013-09-25 14:59:51 UTC) #2

Toon Verwaest

7 years, 2 months ago (2013-09-25 15:12:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16944 (presubmit successful).

Expand Messages | Collapse Messages