|
|
Created:
4 years, 1 month ago by tdanderson Modified:
4 years, 1 month ago CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable Ash material design shelf and system menu by default
Enables the new Ash material design shelf and system
menu by default.
BUG=598794
Committed: https://crrev.com/b366dd9b64344b7bf108a4a3cfb23de0e7bb384c
Cr-Commit-Position: refs/heads/master@{#429057}
Patch Set 1 #Patch Set 2 : do not set experimental as default #Patch Set 3 : rebase #
Messages
Total messages: 40 (29 generated)
tdanderson@chromium.org changed reviewers: + jamescook@chromium.org
James, can you please take a look? There are still two CLs I plan on landing before this one, but this otherwise has PM and UI approval to be enabled in M-56 dev and canary channels.
The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Woo hoo! Nice to see this going out to users by default.
(If there's a launch bug for this, maybe cite that one in addition, or instead? That bug is about tests.)
The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by setting ash::MaterialDesignController::DefaultMode() to be MATERIAL_EXPERIMENTAL; this enables all remaining material design work by default. BUG=617296 ========== to ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by setting ash::MaterialDesignController::DefaultMode() to be MATERIAL_EXPERIMENTAL; this enables all remaining material design work by default. BUG=598794 ==========
Description was changed from ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by setting ash::MaterialDesignController::DefaultMode() to be MATERIAL_EXPERIMENTAL; this enables all remaining material design work by default. BUG=598794 ========== to ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 ==========
tdanderson@chromium.org changed reviewers: + varkha@chromium.org
James and Valery, can you please take another look? Patch set 1 was not going to work, as I did not realize that Valery was still using the EXPERIMENTAL mode for experimental feature development beyond the shelf and system menu :) Also, bug number has been updated to the launch bug.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Code LGTM but you've got some test failures you'll have to sort out.
LGTM (once the tests are sorted out).
The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tdanderson@chromium.org
The CQ bit was checked by tdanderson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org, varkha@chromium.org Link to the patchset: https://codereview.chromium.org/2454393002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tdanderson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 ========== to ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 ========== to ========== Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 Committed: https://crrev.com/b366dd9b64344b7bf108a4a3cfb23de0e7bb384c Cr-Commit-Position: refs/heads/master@{#429057} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b366dd9b64344b7bf108a4a3cfb23de0e7bb384c Cr-Commit-Position: refs/heads/master@{#429057} |