Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2454393002: Enable Ash material design shelf and system menu by default (Closed)

Created:
4 years, 1 month ago by tdanderson
Modified:
4 years, 1 month ago
Reviewers:
James Cook, varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Ash material design shelf and system menu by default Enables the new Ash material design shelf and system menu by default. BUG=598794 Committed: https://crrev.com/b366dd9b64344b7bf108a4a3cfb23de0e7bb384c Cr-Commit-Position: refs/heads/master@{#429057}

Patch Set 1 #

Patch Set 2 : do not set experimental as default #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M ash/common/material_design/material_design_controller.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/shelf_constants.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 40 (29 generated)
tdanderson
James, can you please take a look? There are still two CLs I plan on ...
4 years, 1 month ago (2016-10-28 16:36:09 UTC) #2
James Cook
LGTM. Woo hoo! Nice to see this going out to users by default.
4 years, 1 month ago (2016-10-28 20:57:09 UTC) #7
James Cook
(If there's a launch bug for this, maybe cite that one in addition, or instead? ...
4 years, 1 month ago (2016-10-28 20:57:44 UTC) #8
tdanderson
James and Valery, can you please take another look? Patch set 1 was not going ...
4 years, 1 month ago (2016-10-28 21:28:44 UTC) #14
James Cook
Code LGTM but you've got some test failures you'll have to sort out.
4 years, 1 month ago (2016-10-29 00:11:06 UTC) #17
varkha
LGTM (once the tests are sorted out).
4 years, 1 month ago (2016-10-29 00:58:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454393002/40001
4 years, 1 month ago (2016-10-31 21:35:24 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/306101)
4 years, 1 month ago (2016-10-31 22:55:42 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454393002/40001
4 years, 1 month ago (2016-11-01 17:59:16 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 18:27:00 UTC) #38
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:54:21 UTC) #40
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b366dd9b64344b7bf108a4a3cfb23de0e7bb384c
Cr-Commit-Position: refs/heads/master@{#429057}

Powered by Google App Engine
This is Rietveld 408576698