Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*

Committed: https://crrev.com/41c89184c969af97c6b9ac9f262f051b5557fdfc
Cr-Commit-Position: refs/heads/master@{#427636}

[hajimehoshi, 2016-10-25 10:13:34]

hajimehoshi@chromium.org changed reviewers:
+ avi@chromium.org, bashi@chromium.org, chrisha@chromium.org,
danakj@chromium.org, haraken@chromium.org

[hajimehoshi, 2016-10-25 10:13:34]

PTAL

[hajimehoshi, 2016-10-25 10:22:43]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 10:23:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 10:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:24:57]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[hajimehoshi, 2016-10-25 10:37:01]

Patchset #1 (id:1) has been deleted

[haraken, 2016-10-25 10:40:58]

Can we add a test?

[hajimehoshi, 2016-10-25 10:47:48]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 10:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-10-25 11:07:13]

Description was changed from

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
==========

to

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
/content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

[hajimehoshi, 2016-10-25 11:07:26]

Description was changed from

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
/content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

to

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

[hajimehoshi, 2016-10-25 11:07:32]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[hajimehoshi, 2016-10-25 11:07:35]

On 2016/10/25 10:40:58, haraken wrote:
> Can we add a test?

Done.

[commit-bot: I haz the power, 2016-10-25 11:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 12:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 12:00:29]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-10-25 12:29:15]

LGTM

[Avi (use Gerrit), 2016-10-25 15:11:21]

lgtm

[danakj, 2016-10-25 20:16:39]

LGTM

[bashi, 2016-10-25 23:29:02]

https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl.cc:119: current_state_ =
memory_state;
Don't we have to trigger OnMemoryStateChange() for clients and child processes?

[hajimehoshi, 2016-10-26 07:12:44]

Thank you!

https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl.cc:119: current_state_ =
memory_state;
On 2016/10/25 23:29:02, bashi1 wrote:
> Don't we have to trigger OnMemoryStateChange() for clients and child
processes?

Done.

[haraken, 2016-10-26 07:15:08]

On 2016/10/26 07:12:44, hajimehoshi wrote:
> Thank you!
> 
>
https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
> File content/browser/memory/memory_coordinator_impl.cc (right):
> 
>
https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
> content/browser/memory/memory_coordinator_impl.cc:119: current_state_ =
> memory_state;
> On 2016/10/25 23:29:02, bashi1 wrote:
> > Don't we have to trigger OnMemoryStateChange() for clients and child
> processes?
> 
> Done.

Can we add a test for this?

[hajimehoshi, 2016-10-26 07:34:36]

On 2016/10/26 07:15:08, haraken wrote:
> On 2016/10/26 07:12:44, hajimehoshi wrote:
> > Thank you!
> > 
> >
>
https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
> > File content/browser/memory/memory_coordinator_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/2448953002/diff/60001/content/browser/memory/...
> > content/browser/memory/memory_coordinator_impl.cc:119: current_state_ =
> > memory_state;
> > On 2016/10/25 23:29:02, bashi1 wrote:
> > > Don't we have to trigger OnMemoryStateChange() for clients and child
> > processes?
> > 
> > Done.
> 
> Can we add a test for this?

Yes, we can! Done.

[hajimehoshi, 2016-10-26 07:34:45]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-10-26 07:35:31]

LGTM

[bashi, 2016-10-26 07:36:27]

lgtm

[hajimehoshi, 2016-10-26 07:38:49]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2016-10-26 07:38:50]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-10-26 07:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2448953002/#ps100001
(title: "Add tests")

[commit-bot: I haz the power, 2016-10-26 07:39:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 08:35:18]

Description was changed from

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

to

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

[commit-bot: I haz the power, 2016-10-26 08:35:19]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-26 08:39:08]

Description was changed from

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*
==========

to

==========
Add MemoryCoordinatorProxy::SetCurrentMemoryStateForTesting

This CL instroduces MemoryCoordinatorProxy::
SetCurrentMemoryStateForTesting to set the current memory state for
testing. This is needed to cover MemoryCoordinatorClients functions in
tests.

BUG=639700
TEST=content_unittests --gtest_filter=MemoryCoordinatorImplTest.*

Committed: https://crrev.com/41c89184c969af97c6b9ac9f262f051b5557fdfc
Cr-Commit-Position: refs/heads/master@{#427636}
==========

[commit-bot: I haz the power, 2016-10-26 08:39:10]

Patchset 5 (id:??) landed as
https://crrev.com/41c89184c969af97c6b9ac9f262f051b5557fdfc
Cr-Commit-Position: refs/heads/master@{#427636}