Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: media/gpu/android_video_decode_accelerator.cc

Issue 2447463002: Remove some unneeded media.AVDA histograms. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/gpu/avda_picture_buffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/android_video_decode_accelerator.cc
diff --git a/media/gpu/android_video_decode_accelerator.cc b/media/gpu/android_video_decode_accelerator.cc
index f7851da8ec568a94f7efa2675b5207c98946f983..ccc9f0b90a657923fe19d20cb65b51a1f26af782 100644
--- a/media/gpu/android_video_decode_accelerator.cc
+++ b/media/gpu/android_video_decode_accelerator.cc
@@ -111,16 +111,6 @@ constexpr base::TimeDelta IdleTimerTimeOut = base::TimeDelta::FromSeconds(1);
// from breaking the pipeline, if we're about to be reset anyway.
constexpr base::TimeDelta ErrorPostingDelay = base::TimeDelta::FromSeconds(2);
-// For RecordFormatChangedMetric.
-enum FormatChangedValue {
- CodecInitialized = false,
- MissingFormatChanged = true
-};
-
-inline void RecordFormatChangedMetric(FormatChangedValue value) {
- UMA_HISTOGRAM_BOOLEAN("Media.AVDA.MissingFormatChanged", !!value);
-}
-
} // namespace
static base::LazyInstance<AVDACodecAllocator>::Leaky g_avda_codec_allocator =
@@ -755,11 +745,8 @@ bool AndroidVideoDecodeAccelerator::DequeueOutput() {
}
if (!picturebuffers_requested_) {
- // If, somehow, we get a decoded frame back before a FORMAT_CHANGED
- // message, then we might not have any picture buffers to use. This
- // isn't supposed to happen (see EncodeDecodeTest.java#617).
- // Log a metric to see how common this is.
- RecordFormatChangedMetric(FormatChangedValue::MissingFormatChanged);
+ // In 0.01% of playbacks MediaCodec returns a frame before FORMAT_CHANGED.
+ // Occurs on JB and M. (See the Media.AVDA.MissingFormatChanged histogram.)
media_codec_->ReleaseOutputBuffer(buf_index, false);
POST_ERROR(PLATFORM_FAILURE, "Dequeued buffers before FORMAT_CHANGED.");
return false;
@@ -1059,9 +1046,6 @@ void AndroidVideoDecodeAccelerator::OnCodecConfigured(
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(state_ == WAITING_FOR_CODEC || state_ == SURFACE_DESTROYED);
- // Record one instance of the codec being initialized.
- RecordFormatChangedMetric(FormatChangedValue::CodecInitialized);
-
// If we are supposed to notify that initialization is complete, then do so
// now. Otherwise, this is a reconfiguration.
if (deferred_initialization_pending_) {
« no previous file with comments | « no previous file | media/gpu/avda_picture_buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698