Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 24467004: [webcrypto] Remove MockWebCrypto. (Closed)

Created:
7 years, 2 months ago by eroman
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, jeez, dglazkov+blink, abarth-chromium, Bryan Eyler, Ryan Sleevi
Visibility:
Public.

Description

[webcrypto] Remove MockWebCrypto. After a forthcoming Chromium-side change, Blink will be using the chromium-provided WebCryptoImpl rather than MockWebCrypto. The consequence is the layout test and expectations need to be modified a bit since (a) some features will no longer be testable, and (b) other results that were hardcoded by the mock must be updated. There is a slight coverage hit from this change, however that will be fixed gradually as the layout tests are updated to match the bits implemented by chromium side. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158426

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove some unused params #

Total comments: 4

Patch Set 4 : Delete unused code in layout-tests and fix include of .cpp! #

Patch Set 5 : rebase #

Patch Set 6 : fix rebase #

Patch Set 7 : Inline the virtual functions instead of exporting #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -402 lines) Patch
M LayoutTests/crypto/digest.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/crypto/digest-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/crypto/exportKey.html View 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/crypto/exportKey-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/crypto/generateKey.html View 1 2 3 2 chunks +0 lines, -57 lines 0 comments Download
M LayoutTests/crypto/generateKey-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/crypto/importKey.html View 6 chunks +10 lines, -23 lines 0 comments Download
M LayoutTests/crypto/importKey-expected.txt View 1 chunk +4 lines, -8 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 2 3 4 5 2 chunks +10 lines, -7 lines 0 comments Download
M LayoutTests/crypto/sign-verify.html View 1 2 3 1 chunk +2 lines, -28 lines 0 comments Download
M LayoutTests/crypto/sign-verify-expected.txt View 1 chunk +1 line, -11 lines 0 comments Download
D Source/testing/runner/MockWebCrypto.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/testing/runner/MockWebCrypto.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
M Source/testing/runner/WebTestInterfaces.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/testing/runner/runner.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebCrypto.h View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M public/testing/WebTestInterfaces.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
7 years, 2 months ago (2013-09-26 00:34:00 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/24467004/diff/8001/LayoutTests/crypto/generateKey.html File LayoutTests/crypto/generateKey.html (right): https://codereview.chromium.org/24467004/diff/8001/LayoutTests/crypto/generateKey.html#newcode75 LayoutTests/crypto/generateKey.html:75: /* TODO(eroman): generateKey() is implemented yet. Can we ...
7 years, 2 months ago (2013-09-26 04:22:26 UTC) #2
eroman
https://codereview.chromium.org/24467004/diff/8001/Source/core/platform/chromium/support/WebCrypto.cpp File Source/core/platform/chromium/support/WebCrypto.cpp (right): https://codereview.chromium.org/24467004/diff/8001/Source/core/platform/chromium/support/WebCrypto.cpp#newcode34 Source/core/platform/chromium/support/WebCrypto.cpp:34: #include "core/platform/NotImplemented.cpp" On 2013/09/26 04:22:27, abarth wrote: > #include ...
7 years, 2 months ago (2013-09-26 06:54:07 UTC) #3
eroman
https://codereview.chromium.org/24467004/diff/8001/LayoutTests/crypto/generateKey.html File LayoutTests/crypto/generateKey.html (right): https://codereview.chromium.org/24467004/diff/8001/LayoutTests/crypto/generateKey.html#newcode75 LayoutTests/crypto/generateKey.html:75: /* TODO(eroman): generateKey() is implemented yet. On 2013/09/26 04:22:27, ...
7 years, 2 months ago (2013-09-26 18:07:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24467004/27001
7 years, 2 months ago (2013-09-27 05:26:57 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-27 06:01:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24467004/44001
7 years, 2 months ago (2013-09-27 07:01:30 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 07:57:43 UTC) #8
Message was sent while issue was closed.
Change committed as 158426

Powered by Google App Engine
This is Rietveld 408576698