Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2445463002: Fix null-check in SVGLengthContext::convertValueFromCHSToUserUnits (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, rwlbuis, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null-check in SVGLengthContext::convertValueFromCHSToUserUnits BUG=657438 R=pdr@chromium.org Committed: https://crrev.com/ca7b171d703b3bc08e2a141901a1640a913ef95a Cr-Commit-Position: refs/heads/master@{#426987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/svg/SVGLengthContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
eae
4 years, 2 months ago (2016-10-21 22:14:32 UTC) #1
pdr.
On 2016/10/21 at 22:14:32, eae wrote: > LGTM
4 years, 2 months ago (2016-10-21 22:15:07 UTC) #2
eae
Thanks. This was due to a silly mistake in my last patch. Luckily clusterfuzz caught ...
4 years, 2 months ago (2016-10-21 22:28:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445463002/1
4 years, 2 months ago (2016-10-21 22:41:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/321744)
4 years, 2 months ago (2016-10-22 02:18:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445463002/1
4 years, 2 months ago (2016-10-22 05:23:01 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-22 06:54:33 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 06:56:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca7b171d703b3bc08e2a141901a1640a913ef95a
Cr-Commit-Position: refs/heads/master@{#426987}

Powered by Google App Engine
This is Rietveld 408576698