Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2445453002: Add a base::Feature to change progress bar completion policy. (Closed)

Created:
4 years, 2 months ago by Nate Chapin
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a base::Feature to change progress bar completion policy. A command line flag will take priority. If none is present, the Feature will be used to determine the policy. BUG=651646 Committed: https://crrev.com/76a28a8d25f87f73dc2aa94f721e80cbf0666cc3 Cr-Commit-Position: refs/heads/master@{#426961}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bracket spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/common/content_switches_internal.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Nate Chapin
4 years, 2 months ago (2016-10-21 21:55:59 UTC) #3
Charlie Reis
LGTM https://codereview.chromium.org/2445453002/diff/1/content/common/content_switches_internal.cc File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2445453002/diff/1/content/common/content_switches_internal.cc#newcode40 content/common/content_switches_internal.cc:40: const base::Feature kProgressBarCompletionResourcesBeforeDOMContentLoaded{ nit: Is there room for ...
4 years, 2 months ago (2016-10-21 22:07:21 UTC) #4
Nate Chapin
https://codereview.chromium.org/2445453002/diff/1/content/common/content_switches_internal.cc File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2445453002/diff/1/content/common/content_switches_internal.cc#newcode40 content/common/content_switches_internal.cc:40: const base::Feature kProgressBarCompletionResourcesBeforeDOMContentLoaded{ On 2016/10/21 22:07:20, Charlie Reis wrote: ...
4 years, 2 months ago (2016-10-21 22:09:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445453002/20001
4 years, 2 months ago (2016-10-21 22:11:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 03:08:28 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 03:11:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76a28a8d25f87f73dc2aa94f721e80cbf0666cc3
Cr-Commit-Position: refs/heads/master@{#426961}

Powered by Google App Engine
This is Rietveld 408576698