Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2445123002: Make blink settings/features case-sensitive (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr., skobes
CC:
chromium-reviews, Dirk Pranke, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make blink setting/feature names case-sensitive Previously we match blink setting/feature names ignoring case. This causes trouble when the name is used in a case-sensitive environment, e.g. Linux file system. Make them case-sensitive to avoid the trouble. third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=slimmingPaintInvalidation which is a violation of the new case-sensitive rule is removed in this CL. It will be re-added in https://codereview.chromium.org/2448633002/ to avoid problems on platforms using case-insensitive file names. Committed: https://crrev.com/1e4fbec3b5701d9f605e88f14dafa442be98b648 Cr-Commit-Position: refs/heads/master@{#427219}

Patch Set 1 #

Patch Set 2 : Remove the files first and will readthe files and will re-add them in a later patch because the ren… #

Patch Set 3 : case-sensitive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -47 lines) Patch
D third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=slimmingPaintInvalidation View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 1 2 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (12 generated)
Xianzhu
4 years, 1 month ago (2016-10-24 20:56:26 UTC) #3
pdr.
Nice find! What if we made --enable-blink-features case sensitive (in WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl)? I worry that having ...
4 years, 1 month ago (2016-10-24 21:44:16 UTC) #10
Xianzhu
On 2016/10/24 21:44:16, pdr. wrote: > Nice find! > > What if we made --enable-blink-features ...
4 years, 1 month ago (2016-10-24 22:12:15 UTC) #11
pdr.
On 2016/10/24 at 22:12:15, wangxianzhu wrote: > On 2016/10/24 21:44:16, pdr. wrote: > > Nice ...
4 years, 1 month ago (2016-10-24 22:19:50 UTC) #12
Xianzhu
On 2016/10/24 22:19:50, pdr. wrote: > On 2016/10/24 at 22:12:15, wangxianzhu wrote: > > On ...
4 years, 1 month ago (2016-10-24 22:56:08 UTC) #13
Xianzhu
On 2016/10/24 22:56:08, Xianzhu wrote: > On 2016/10/24 22:19:50, pdr. wrote: > > On 2016/10/24 ...
4 years, 1 month ago (2016-10-24 23:27:48 UTC) #14
Xianzhu
On 2016/10/24 23:27:48, Xianzhu wrote: > On 2016/10/24 22:56:08, Xianzhu wrote: > > On 2016/10/24 ...
4 years, 1 month ago (2016-10-24 23:32:12 UTC) #16
pdr.
Looks great! LGTM
4 years, 1 month ago (2016-10-24 23:33:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445123002/40001
4 years, 1 month ago (2016-10-24 23:36:30 UTC) #19
skobes
lgtm
4 years, 1 month ago (2016-10-24 23:51:26 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 01:35:00 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:36:37 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e4fbec3b5701d9f605e88f14dafa442be98b648
Cr-Commit-Position: refs/heads/master@{#427219}

Powered by Google App Engine
This is Rietveld 408576698