Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2444643002: Print Preview: Add the list entire list of cloud print media sizes. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 1 month ago
CC:
arv+watch_chromium.org, chromium-reviews, paolof_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Add the list entire list of cloud print media sizes. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/263321a3c439d9872438f1904d1570573b7e7d9b Cr-Commit-Position: refs/heads/master@{#427206}

Patch Set 1 #

Total comments: 5

Patch Set 2 : commas #

Patch Set 3 : decl once #

Total comments: 4

Patch Set 4 : address comments, put back 'Tabloid' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -22 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 1 2 3 2 chunks +178 lines, -22 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Lei Zhang
https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (left): https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#oldcode357 chrome/browser/resources/print_preview/data/destination_store.js:357: 'NA_LEDGER': 'Tabloid', I asked on https://codereview.chromium.org/294923005/ why this is. ...
4 years, 2 months ago (2016-10-22 02:11:06 UTC) #4
dpapad
https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode345 chrome/browser/resources/print_preview/data/destination_store.js:345: var mediaDisplayNames = { Now that this object got ...
4 years, 1 month ago (2016-10-24 18:14:56 UTC) #9
Lei Zhang
https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2444643002/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode345 chrome/browser/resources/print_preview/data/destination_store.js:345: var mediaDisplayNames = { On 2016/10/24 18:14:56, dpapad wrote: ...
4 years, 1 month ago (2016-10-24 19:30:52 UTC) #11
dpapad
LGTM with nits. https://codereview.chromium.org/2444643002/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2444643002/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js#newcode311 chrome/browser/resources/print_preview/data/destination_store.js:311: * @const {number} I think the ...
4 years, 1 month ago (2016-10-24 20:53:53 UTC) #13
Lei Zhang
https://codereview.chromium.org/2444643002/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2444643002/diff/40001/chrome/browser/resources/print_preview/data/destination_store.js#newcode311 chrome/browser/resources/print_preview/data/destination_store.js:311: * @const {number} On 2016/10/24 20:53:53, dpapad wrote: > ...
4 years, 1 month ago (2016-10-24 21:00:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444643002/60001
4 years, 1 month ago (2016-10-24 21:02:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93279)
4 years, 1 month ago (2016-10-24 21:21:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444643002/60001
4 years, 1 month ago (2016-10-24 22:20:31 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 01:11:14 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/263321a3c439d9872438f1904d1570573b7e7d9b Cr-Commit-Position: refs/heads/master@{#427206}
4 years, 1 month ago (2016-10-25 01:13:46 UTC) #25
Aleksey Shlyapnikov
As a suggestion, with media set this big, I'd start planning on structuring media selection ...
4 years, 1 month ago (2016-10-25 16:33:58 UTC) #27
Lei Zhang
On 2016/10/25 16:33:58, Aleksey Shlyapnikov wrote: > As a suggestion, with media set this big, ...
4 years, 1 month ago (2016-10-25 17:13:46 UTC) #28
Aleksey Shlyapnikov
4 years, 1 month ago (2016-10-25 21:32:36 UTC) #29
Message was sent while issue was closed.
On 2016/10/25 17:13:46, Lei Zhang wrote:
> On 2016/10/25 16:33:58, Aleksey Shlyapnikov wrote:
> > As a suggestion, with media set this big, I'd start planning on structuring
> > media selection dropdown. For example, GCP groups media by standard/region
> (ISO,
> > NA, JIS etc.)
> 
> Yes, I noticed the GCP website does this. I implemented the sorting earlier in
> https://crrev.com/426311 .

Oh, sorry, my bad, should've checked the code out first. Thank you!

Powered by Google App Engine
This is Rietveld 408576698