Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3213)

Unified Diff: cc/output/output_surface.h

Issue 2444603002: cc: Fix comments in OutputSurface, it is no longer for layer compositor (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/output_surface.h
diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h
index 4b6c1121582d52d632af239ddca615686afe8e53..819f46b65f7b6675116bcc13fd661e3d9ce45e65 100644
--- a/cc/output/output_surface.h
+++ b/cc/output/output_surface.h
@@ -37,13 +37,9 @@ struct ManagedMemoryPolicy;
class OutputSurfaceClient;
class OutputSurfaceFrame;
-// Represents the output surface for a compositor. The compositor owns
-// and manages its destruction. Its lifetime is:
-// 1. Created on the main thread by the LayerTreeHost through its client.
-// 2. Passed to the compositor thread and bound to a client via BindToClient.
-// From here on, it will only be used on the compositor thread.
-// 3. If the 3D context is lost, then the compositor will delete the output
-// surface (on the compositor thread) and go back to step 1.
+// This class represents a platform-independent API for presenting
+// buffers to display via GPU or software compositing. Implementations
+// can provide platform-specific behaviour.
class CC_EXPORT OutputSurface {
public:
struct Capabilities {
@@ -67,10 +63,9 @@ class CC_EXPORT OutputSurface {
virtual ~OutputSurface();
- // Called by the compositor on the compositor thread. This is a place where
- // thread-specific data for the output surface can be initialized. The
- // OutputSurface will be destroyed on the same thread that BoundToClient is
- // called on.
+ // Called by the Display to initialize the OutputSurface. This also specifies
+ // the thread that the OutputSurface will be used on as tests create and then
+ // bind the class on different threads.
virtual bool BindToClient(OutputSurfaceClient* client);
const Capabilities& capabilities() const { return capabilities_; }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698