Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2444473002: Add gtk3 dev files to sysroot (Closed)

Created:
4 years, 2 months ago by Tom (Use chromium acct)
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Elliot Glaysher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gtk3 dev files to sysroot This CL makes it possible to run "gn gen" with use_gtk3=true and use_sysroot=true. This is a first step toward adding build support on the bots so we can have continuous integration in this area. BUG=132847 R=thestig@chromium.org Committed: https://crrev.com/bcb34061acbe90a5ca4e73a50e12f9ecf2141758 Cr-Commit-Position: refs/heads/master@{#426910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +12 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.precise.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 4 chunks +7 lines, -5 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-precise.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Tom (Use chromium acct)
+thestig@ for review +erg@ FYI
4 years, 2 months ago (2016-10-21 19:31:06 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-21 20:41:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444473002/1
4 years, 2 months ago (2016-10-21 21:47:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 22:11:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 22:26:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcb34061acbe90a5ca4e73a50e12f9ecf2141758
Cr-Commit-Position: refs/heads/master@{#426910}

Powered by Google App Engine
This is Rietveld 408576698