Avoid element id collisions with the visual viewport

Avoid element id collisions with the visual viewport

The frame scroll layer and the inner viewport layer had previously been
given the same element id.

BUG=658252
Committed: https://crrev.com/d0124a2b6302fc8a5b3c335d5bbb0407a8a31bb4
Cr-Commit-Position: refs/heads/master@{#426928}

[Ian Vollick, 2016-10-21 18:27:55]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 18:28:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2016-10-21 18:28:39]

vollick@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2016-10-21 18:32:28]

https://codereview.chromium.org/2443633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/VisualViewport.cpp (right):

https://codereview.chromium.org/2443633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/VisualViewport.cpp:396:
DOMNodeIds::idForNode(document), CompositorSubElementId::Scroll));
Should this be using the new Viewport subelement enum you added?

[Ian Vollick, 2016-10-21 18:35:35]

On 2016/10/21 18:32:28, bokan wrote:
>
https://codereview.chromium.org/2443633002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/VisualViewport.cpp (right):
> 
>
https://codereview.chromium.org/2443633002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/VisualViewport.cpp:396:
> DOMNodeIds::idForNode(document), CompositorSubElementId::Scroll));
> Should this be using the new Viewport subelement enum you added?

Whoops, I changed the value to Scroll to ensure that my test would fail, but it
looks like I forgot to change it back :)

Yes, it should definitely be the other subelement.

[Ian Vollick, 2016-10-21 18:36:45]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 18:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2016-10-21 18:40:26]

lgtm

[Ian Vollick, 2016-10-21 18:41:10]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 18:41:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:53:56]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2016-10-21 23:22:05]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2016-10-21 23:22:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2443633002/#ps40001
(title: "fix typo.")

[commit-bot: I haz the power, 2016-10-21 23:22:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 23:47:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 23:50:23]

Description was changed from

==========
Avoid element id collisions with the visual viewport

The frame scroll layer and the inner viewport layer had previously been
given the same element id.

BUG=658252
==========

to

==========
Avoid element id collisions with the visual viewport

The frame scroll layer and the inner viewport layer had previously been
given the same element id.

BUG=658252

Committed: https://crrev.com/d0124a2b6302fc8a5b3c335d5bbb0407a8a31bb4
Cr-Commit-Position: refs/heads/master@{#426928}
==========

[commit-bot: I haz the power, 2016-10-21 23:50:24]

Patchset 3 (id:??) landed as
https://crrev.com/d0124a2b6302fc8a5b3c335d5bbb0407a8a31bb4
Cr-Commit-Position: refs/heads/master@{#426928}